From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D45AC43381 for ; Mon, 1 Apr 2019 18:08:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DFF920663 for ; Mon, 1 Apr 2019 18:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554142122; bh=Zh2H0PR4BDDk+orn8PUR+JrIz72YhO7J3+Xq3nTdklU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AiRJ8zmAQF0LZt8swdDfpRH2AVjMIaFR3Bx8bGwySP0mBtVOiDRMtBzJvFBYDbpGy sRK6SFLM76sQpUwbRFhPAM08DxVC/PLJ0EC4UvtwIKneRwwjlKum26iXO61x18yepr A5IlzVBByZzdGqGvmK/21tAnSifYONDkXW3y+Uyo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729532AbfDARJ5 (ORCPT ); Mon, 1 Apr 2019 13:09:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:57238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729042AbfDARJ4 (ORCPT ); Mon, 1 Apr 2019 13:09:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9553D21924; Mon, 1 Apr 2019 17:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554138596; bh=Zh2H0PR4BDDk+orn8PUR+JrIz72YhO7J3+Xq3nTdklU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gSaaX6RnmviI4mdAtnhZ5b2fq9PNWYJCGxaj6NHomxjPq6D5/Ek/JAoE/tTFQ4Ubr 9V1xLl4ks41YVghmNQJBWfX6wWI/tzBtgPOb8HWYPrCj3nQU8TKzinZXskRexKpRbR hzvwQth7NDgyuE5T/tD+ZOXdYlddwe51+HI8HgzI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Malcolm Priestley Subject: [PATCH 5.0 085/146] staging: vt6655: Remove vif check from vnt_interrupt Date: Mon, 1 Apr 2019 19:01:37 +0200 Message-Id: <20190401170056.022744604@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170048.449559024@linuxfoundation.org> References: <20190401170048.449559024@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Malcolm Priestley commit cc26358f89c3e493b54766b1ca56cfc6b14db78a upstream. A check for vif is made in vnt_interrupt_work. There is a small chance of leaving interrupt disabled while vif is NULL and the work hasn't been scheduled. Signed-off-by: Malcolm Priestley CC: stable@vger.kernel.org # v4.2+ Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6655/device_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1139,8 +1139,7 @@ static irqreturn_t vnt_interrupt(int irq { struct vnt_private *priv = arg; - if (priv->vif) - schedule_work(&priv->interrupt_work); + schedule_work(&priv->interrupt_work); return IRQ_HANDLED; }