From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9050C43381 for ; Tue, 2 Apr 2019 01:06:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C188A20833 for ; Tue, 2 Apr 2019 01:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbfDBBGJ (ORCPT ); Mon, 1 Apr 2019 21:06:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31528 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfDBBGI (ORCPT ); Mon, 1 Apr 2019 21:06:08 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99E92C049598; Tue, 2 Apr 2019 01:06:08 +0000 (UTC) Received: from ming.t460p (ovpn-8-17.pek2.redhat.com [10.72.8.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 061585D6A6; Tue, 2 Apr 2019 01:05:59 +0000 (UTC) Date: Tue, 2 Apr 2019 09:05:55 +0800 From: Ming Lei To: Greg KH Cc: Sasha Levin , Yi Zhang , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, stable@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Message-ID: <20190402010553.GE21944@ming.t460p> References: <20190327090230.12671-1-ming.lei@redhat.com> <20190327161658.GL25262@sasha-vm> <20190328005505.GB19708@ming.t460p> <20190401135509.GC23581@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190401135509.GC23581@kroah.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 02 Apr 2019 01:06:08 +0000 (UTC) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 01, 2019 at 03:55:09PM +0200, Greg KH wrote: > On Thu, Mar 28, 2019 at 08:55:06AM +0800, Ming Lei wrote: > > On Wed, Mar 27, 2019 at 12:16:58PM -0400, Sasha Levin wrote: > > > On Wed, Mar 27, 2019 at 05:02:30PM +0800, Ming Lei wrote: > > > > NVMe target only accepts single-page sg list, either file or block > > > > device backed target code follows this assumption. > > > > > > > > However, loop target is one exception, given the sg list is from > > > > the host queue directly. > > > > > > > > This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 > > > > for following NVMe target assumption. > > > > > > > > Reported-by: Yi Zhang > > > > Fixes: 3a85a5de29ea ("nvme-loop: add a NVMe loopback host driver") > > > > Cc: Yi Zhang > > > > Cc: Sagi Grimberg > > > > Cc: Chaitanya Kulkarni > > > > Cc: > > > > Signed-off-by: Ming Lei > > > > > > Could you provide some background as to why this is -stable only in the > > > commit message? > > > > Multi-page bvec has been merged to linus tree already, so the following > > patch simply can fix the current issue without needing to limit the segment > > size for nvme-loop: > > > > http://lists.infradead.org/pipermail/linux-nvme/2019-March/023105.html > > Can you resend the patch with this needed information in it? Also, I > don't understand what you are referring to with that url, why can't we > just use that patch? Sure, will resend the patch with the above info soon. Thanks, Ming