From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88AB3C4360F for ; Wed, 3 Apr 2019 14:04:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55FE12075E for ; Wed, 3 Apr 2019 14:04:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="Oa4CzlZm"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="mUZziC86" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726387AbfDCOEc (ORCPT ); Wed, 3 Apr 2019 10:04:32 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:45091 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726372AbfDCOEc (ORCPT ); Wed, 3 Apr 2019 10:04:32 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 1E37E631B; Wed, 3 Apr 2019 10:04:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 03 Apr 2019 10:04:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=pjS3CPOSyEQhnWY059e5NL0T/bR /vZOtd7BuJRJFAb4=; b=Oa4CzlZmwmG9MHMZ+mVGj8u8x7AFLg0iz7nU/KZ5Z/C WZ2quhyy5ToOPTxszkTCh5XWCdcpczoFOp2y7CKT/p22mhoiki2mLKtTo8j6ARHd EHoDIfssqrUYvm6woFGtn5Hc6EiLu6LlD8aHdiPxqEnn1A36rSipT377Z9uLfDYb 2gZ02mHl6JIwxnQjO/WlsbtYF9JyqjeYMp9a23DY/unV7WuW9h+TAwmm20/E4EvO 5fC302Ed2ZIa3GydWF8qLV1tc5oaY0DUZXAFusKVaffr+JY5/ZCWFuI4tsct+f6C y43LnZ5Gu63aWsuhcB8/VomFoCszIP6Dt8Y0r9aZnKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pjS3CP OSyEQhnWY059e5NL0T/bR/vZOtd7BuJRJFAb4=; b=mUZziC86huqHCDEh296zo2 msHTAf4wXrMxpMFr4dVT9TatC1Y0Hia8RNR5y+XnyjuWJMjGNSxlopvnGCv1cMpi n+MGQLL1IoqnRjZuSkP0xDUanjUqSQSdfb5YeJ37rA9FZRd1dBV3DhImZE3arwO3 ROFXv4L8E7kJxZABVcxDp4GQ7T2wN+A+4ZxOu4zQI8DZE0s3BjVbpoQ8KIFSg3Ew GaNLD93Lkk3vyHq9rLL/cJUfa0DabbjIKUHwjY1BnloqcSPFgxC1Nbs+pRKX8RKa IkS6odgv4FQmA/98kWUIj7qOHJ8MhbB+A0nAZ/HKHVU5YhfGkCkq0JgDCr2/wOZg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdefgdegieculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredv necuhfhrohhmpefirhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkph epvddujedruddtuddrudektddrudefieenucfrrghrrghmpehmrghilhhfrhhomhepghhr vghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (217-101-180-136.cable.dynamic.v4.ziggo.nl [217.101.180.136]) by mail.messagingengine.com (Postfix) with ESMTPA id 61ADF10310; Wed, 3 Apr 2019 10:04:29 -0400 (EDT) Date: Wed, 3 Apr 2019 16:04:27 +0200 From: Greg KH To: Ming Lei Cc: linux-nvme@lists.infradead.org, Christoph Hellwig , Yi Zhang , Sagi Grimberg , Chaitanya Kulkarni , stable@vger.kernel.org Subject: Re: [RESEND PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Message-ID: <20190403140427.GD8633@kroah.com> References: <20190402015610.26320-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190402015610.26320-1-ming.lei@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 02, 2019 at 09:56:10AM +0800, Ming Lei wrote: > NVMe target only accepts single-page sg list, either file or block > device backed target code follows this assumption. > > However, loop target is one exception, given the sg list is from > the host queue directly. > > This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 > for following NVMe target assumption. > > Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36 > ("nvmet: fix building bvec from sg list") can fix the current issue > simply without needing to limit the segment size for nvme-loop. I don't understand, 02db99548d36 does not work for older kernels, so because of that, you need/want this patch to be applied? If so, what specific kernel versions do you want this to go to? thanks, greg k-h