From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75316C4360F for ; Wed, 3 Apr 2019 14:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B1AB20882 for ; Wed, 3 Apr 2019 14:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554300467; bh=bhvDHXhdSNk8IrvY9+Mf3U+U5Tqr0Gg/WFV2Ev5kdo0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=d/CAJQQ78KeDhgqTiS46Ad2r2eb/2njJITU/yB3i11Zk/lKMB9TbZMX4arccxLFGA n5rHrPhx22p65jVHwCLrkyOtbHHta7V6yN7Eb4D4ATa7Rl/XgoGjDeX2azBrRD4k9z PxdER1B1k90/RFhYuLooCM59Ms4NMfCP3XJ0vJYI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726105AbfDCOHq (ORCPT ); Wed, 3 Apr 2019 10:07:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:34552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfDCOHq (ORCPT ); Wed, 3 Apr 2019 10:07:46 -0400 Received: from localhost (217-101-180-136.cable.dynamic.v4.ziggo.nl [217.101.180.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8302F2084C; Wed, 3 Apr 2019 14:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554300466; bh=bhvDHXhdSNk8IrvY9+Mf3U+U5Tqr0Gg/WFV2Ev5kdo0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GF+Btt8MY1OUZ47j7qhVyOseS5MVeSRWUN3y3hr6VWIO4qsSZQYPoY5FJb/WHNg4c kssanhOxEMp5JiW7uzbgZsqxbfpzkq1YBvi9xCP5U98cwtdrVN4K+gA640AiLX2rtT FNgtudV80vU6I3M9EnO83+tiRDZ8fpM0uzq3pOMk= Date: Wed, 3 Apr 2019 16:07:43 +0200 From: Greg KH To: Zubin Mithra Cc: stable@vger.kernel.org, groeck@chromium.org, mhjungk@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, davem@davemloft.net Subject: Re: [PATCH 4.4.y] Bluetooth: Fix decrementing reference count twice in releasing socket Message-ID: <20190403140743.GG8633@kroah.com> References: <20190401170142.138403-1-zsm@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190401170142.138403-1-zsm@chromium.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 01, 2019 at 10:01:42AM -0700, Zubin Mithra wrote: > From: Myungho Jung > > commit e20a2e9c42c9e4002d9e338d74e7819e88d77162 upstream > > When releasing socket, it is possible to enter hci_sock_release() and > hci_sock_dev_event(HCI_DEV_UNREG) at the same time in different thread. > The reference count of hdev should be decremented only once from one of > them but if storing hdev to local variable in hci_sock_release() before > detached from socket and setting to NULL in hci_sock_dev_event(), > hci_dev_put(hdev) is unexpectedly called twice. This is resolved by > referencing hdev from socket after bt_sock_unlink() in > hci_sock_release(). > > Reported-by: syzbot+fdc00003f4efff43bc5b@syzkaller.appspotmail.com > Signed-off-by: Myungho Jung > Signed-off-by: Marcel Holtmann > Signed-off-by: Zubin Mithra Now applied, thanks. greg k-h