From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5B5C4360F for ; Wed, 3 Apr 2019 16:22:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED49C206C0 for ; Wed, 3 Apr 2019 16:22:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbfDCQWl (ORCPT ); Wed, 3 Apr 2019 12:22:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39326 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbfDCQWk (ORCPT ); Wed, 3 Apr 2019 12:22:40 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 003FB3091747; Wed, 3 Apr 2019 16:22:40 +0000 (UTC) Received: from ming.t460p (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB0CE6012C; Wed, 3 Apr 2019 16:22:31 +0000 (UTC) Date: Thu, 4 Apr 2019 00:22:27 +0800 From: Ming Lei To: Greg KH Cc: Yi Zhang , Sagi Grimberg , Chaitanya Kulkarni , stable@vger.kernel.org, linux-nvme@lists.infradead.org, Christoph Hellwig Subject: Re: [RESEND PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Message-ID: <20190403162226.GA22741@ming.t460p> References: <20190402015610.26320-1-ming.lei@redhat.com> <20190403140427.GD8633@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190403140427.GD8633@kroah.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 03 Apr 2019 16:22:40 +0000 (UTC) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Apr 03, 2019 at 04:04:27PM +0200, Greg KH wrote: > On Tue, Apr 02, 2019 at 09:56:10AM +0800, Ming Lei wrote: > > NVMe target only accepts single-page sg list, either file or block > > device backed target code follows this assumption. > > > > However, loop target is one exception, given the sg list is from > > the host queue directly. > > > > This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 > > for following NVMe target assumption. > > > > Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36 > > ("nvmet: fix building bvec from sg list") can fix the current issue > > simply without needing to limit the segment size for nvme-loop. > > I don't understand, 02db99548d36 does not work for older kernels, so > because of that, you need/want this patch to be applied? If so, what > specific kernel versions do you want this to go to? Old kernel needs both this patch and 02db99548d36, and you should see the description in 02db99548d36 commit log too. This patch should be needed since nvme-loop is introduced. Thanks, Ming