From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20DC2C10F05 for ; Thu, 4 Apr 2019 09:43:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D85EE20693 for ; Thu, 4 Apr 2019 09:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554370988; bh=CZNO1lL9H7pbJ1hSwgb/8om7g63B+27EBD3SWXODV3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rOgs3k/nqpq07Zs01tmSbltvZNqia/GbDhZCY51NQs+kWhlSIkxSfuCbABzcgLYXH mNkqwvBqIERyxGDkrvKDLHzg41/UbG3hIm1orknCm/9f/32ZuST3zmj/bvA0A4cD3p W/QDk+8vX1ELWsgFlbpc9UD5eMklwrOCzJpRwQxA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731109AbfDDJA4 (ORCPT ); Thu, 4 Apr 2019 05:00:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:37844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730796AbfDDJA4 (ORCPT ); Thu, 4 Apr 2019 05:00:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE2992147C; Thu, 4 Apr 2019 09:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554368455; bh=CZNO1lL9H7pbJ1hSwgb/8om7g63B+27EBD3SWXODV3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FkcBrKTIq3JOmuZ7hJapvQX30tI8WE3xiMbhHfHmHTsVSVIIB3WOI+fPUwwNELBXT gXiQi4ZJ6uNH6EytcjYazbpa6W8ZctdnFo+hGjUXR39ioQ1PMLZ/hQ/8s503zE3ZdW n0ecFyZm+BHuLzFArGb9oybmiKp8qHzGpu9a1FXY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Sartain , Mathias Krause , Tony Jones , "Steven Rostedt (VMware)" , Frederic Weisbecker , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.19 046/187] tools lib traceevent: Fix buffer overflow in arg_eval Date: Thu, 4 Apr 2019 10:46:23 +0200 Message-Id: <20190404084605.242178977@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190404084603.119654039@linuxfoundation.org> References: <20190404084603.119654039@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 7c5b019e3a638a5a290b0ec020f6ca83d2ec2aaa ] Fix buffer overflow observed when running perf test. The overflow is when trying to evaluate "1ULL << (64 - 1)" which is resulting in -9223372036854775808 which overflows the 20 character buffer. If is possible this bug has been reported before but I still don't see any fix checked in: See: https://www.spinics.net/lists/linux-perf-users/msg07714.html Reported-by: Michael Sartain Reported-by: Mathias Krause Signed-off-by: Tony Jones Acked-by: Steven Rostedt (VMware) Cc: Frederic Weisbecker Fixes: f7d82350e597 ("tools/events: Add files to create libtraceevent.a") Link: http://lkml.kernel.org/r/20190228015532.8941-1-tonyj@suse.de Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/lib/traceevent/event-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index 75de355a63d6..10985d991ed2 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -2416,7 +2416,7 @@ static int arg_num_eval(struct print_arg *arg, long long *val) static char *arg_eval (struct print_arg *arg) { long long val; - static char buf[20]; + static char buf[24]; switch (arg->type) { case PRINT_ATOM: -- 2.19.1