From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203FDC10F13 for ; Mon, 8 Apr 2019 14:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4F8621473 for ; Mon, 8 Apr 2019 14:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554733524; bh=h4j3Ezzu5W4/eNqfr2573X7kYoecOLnZLw7QhqnBOfo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=u9EKa0eiyzxlcTaMy7JT0/e01BNLQWKL+5MkeWnzPy/JxZ1HK5CXKEe3QzVi4hGjU 1QDrZ9iUiwBchqica3Q8gt4keV5al0WRpsY82QlXAPfJsLSGqJgqicMsSy6gS4KPE5 I2Zm/wtZNAx9l+ZTjY9cDXYJ9zvafOk0AGNe+nC0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726717AbfDHOZX (ORCPT ); Mon, 8 Apr 2019 10:25:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:45830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726716AbfDHOZX (ORCPT ); Mon, 8 Apr 2019 10:25:23 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6396A21473; Mon, 8 Apr 2019 14:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554733522; bh=h4j3Ezzu5W4/eNqfr2573X7kYoecOLnZLw7QhqnBOfo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tjiHV79HrzHDajN7RUuWQ+BJnG8dO8BGyCqkzvfqUZ2Bh9UUA70vje+xJnAEBohR0 v7PXx2/7dxutDiboh+y317yVx3kFVsizWpR3nLwPuQ2zj7PEBiHSU9jCkKXD5+n1Eu B5TG2AZR6nxOzqfrTx9UX92SwsaK2DQeNt0R1OH8= Date: Mon, 8 Apr 2019 10:25:21 -0400 From: Sasha Levin To: Yan Zhao Cc: zhenyuw@linux.intel.com, stable@vger.kernel.org Subject: Re: [PATCH for 4.14] drm/i915/gvt: do not let pin count of shadow mm go negative Message-ID: <20190408142521.GD4689@sasha-vm> References: <20190408051247.3697-1-yan.y.zhao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190408051247.3697-1-yan.y.zhao@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 08, 2019 at 01:12:47AM -0400, Yan Zhao wrote: >shadow mm's pin count got increased in workload preparation phase, which >is after workload scanning. >it will get decreased in complete_current_workload() anyway after >workload completion. >Sometimes, if a workload meets a scanning error, its shadow mm pin count >will not get increased but will get decreased in the end. >This patch lets shadow mm's pin count not go below 0. > >v2: add fixes tag and cc stable kernel (zhenyu wang) >Fixes: 2707e4446688 ("drm/i915/gvt: vGPU graphics memory virtualization") >Cc: zhenyuw@linux.intel.com >Cc: stable@vger.kernel.org #4.14+ >Signed-off-by: Yan Zhao >--- >upstream commit id: 663a50ceac75c2208d2ad95365bc8382fd42f44d >--- > drivers/gpu/drm/i915/gvt/gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c >index dadacbe558ab..1a1f7eb46d1e 100644 >--- a/drivers/gpu/drm/i915/gvt/gtt.c >+++ b/drivers/gpu/drm/i915/gvt/gtt.c >@@ -1629,7 +1629,7 @@ void intel_vgpu_unpin_mm(struct intel_vgpu_mm *mm) > if (WARN_ON(mm->type != INTEL_GVT_MM_PPGTT)) > return; > >- atomic_dec(&mm->pincount); >+ atomic_dec_if_positive(&mm->pincount); > } > > /** Queued for 4.14 (which missing s-o-b from upstream), thanks. -- Thanks, Sasha