From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB3FC10F0E for ; Tue, 9 Apr 2019 15:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24E4720883 for ; Tue, 9 Apr 2019 15:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554823674; bh=CdlA0OK2Q0QrXLwVSsMRmjgENtSzIo6ceF4sR3QVfBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kiWHNXSNt4eA9o9kTKE0oTKSTxD2K1H4/PdXs/CNl6YC1sZ+bb6cAWegSDx9oKLO3 4ngoLDbzs4UQ6r3yewNeoFCyxlbEJ3esGf3YX31NByCCIuFkgLiY/SHiDKjrHfzCJt ZD5n6LdZaHCzbDFqqooaIm6dsKtPq5jm4HXWm2TY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726456AbfDIP1x (ORCPT ); Tue, 9 Apr 2019 11:27:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:50142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfDIP1x (ORCPT ); Tue, 9 Apr 2019 11:27:53 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D0FE820674; Tue, 9 Apr 2019 15:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554823673; bh=CdlA0OK2Q0QrXLwVSsMRmjgENtSzIo6ceF4sR3QVfBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aG2t/xZpc1kw+dT0Z1TwCznF/WlsJwmjhit0nMwCNGq4yuJ2OJoW6qBIYbjcVKCgY hj/ronVbgIrohVSg/rVBkBKtN+/ZbKXumEl1x2KNHU6MY2ao8YjTSH7PSowsuXXAGH XLjTZWr6co0RAksLasYxuvs7+XQWC70a1vdWo4j4= Date: Tue, 9 Apr 2019 11:27:51 -0400 From: Sasha Levin To: Pablo Neira Ayuso Cc: Florian Westphal , stable@vger.kernel.org, Frederik Himpe Subject: Re: 5.0.7: WARNING: CPU: 1 PID: 169 at net/netfilter/nft_compat.c:82 and genreal protection fault Message-ID: <20190409152751.GL4689@sasha-vm> References: <306bc8c0e81422a73ccfcd0ac3ea2d79fc1df0b0.camel@ai.vub.ac.be> <20190408201909.6mcgobkdnswyikfv@breakpoint.cc> <20190409101906.wpoqoyiopvpohaiz@breakpoint.cc> <20190409102110.zct4uqax3pq3n2as@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190409102110.zct4uqax3pq3n2as@salvia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 09, 2019 at 12:21:10PM +0200, Pablo Neira Ayuso wrote: >On Tue, Apr 09, 2019 at 12:19:06PM +0200, Florian Westphal wrote: >> Hello -stable team, >> >> Frederik Himpe wrote: >> > On Mon, 2019-04-08 at 22:19 +0200, Florian Westphal wrote: >> > > Frederik Himpe wrote: >> > > > [ 29.015565] general protection fault: 0000 [#1] SMP PTI >> > > > [ 29.015574] CPU: 3 PID: 2069 Comm: ip6tables-resto Tainted: >> > > >> > > Does this problem go away when you apply this commit on top of 5.0.7? >> > > >> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b8e204006340b7aaf32bd2b9806c692f6e0cb38a >> > >> > Indeed, the problem does not happen any more with this patch applied to >> > 5.0.7. Thanks! >> >> Could you please pick up following patches for 5.0.y? >> Fix tested by Frederik: >> >> b8e204006340b7aaf32bd2b9806c692f6e0cb38a >> netfilter: nft_compat: use .release_ops and remove list of extension >> >> Two followup-ups: >> 3f3a390dbd59d236f62cff8e8b20355ef7069e3d >> netfilter: nf_tables: use-after-free in dynamic operations >> >> b25a31bf0ca091aa8bdb9ab329b0226257568bbe >> netfilter: nf_tables: add missing ->release_ops() in error path of newrule() >> >> These are clean cherry-picks. > >Oh, clash :-) I've queued all 3 for 5.0, thanks! -- Thanks, Sasha