* [PATCH v3 11/26] ceph: fix compat_ioctl for ceph_dir_operations [not found] <20190416202013.4034148-1-arnd@arndb.de> @ 2019-04-16 20:19 ` Arnd Bergmann 2019-04-17 21:23 ` Al Viro 0 siblings, 1 reply; 3+ messages in thread From: Arnd Bergmann @ 2019-04-16 20:19 UTC (permalink / raw) To: Alexander Viro Cc: linux-fsdevel, y2038, linux-kernel, Arnd Bergmann, Yan, Zheng, stable, Sage Weil, Ilya Dryomov, ceph-devel The ceph_ioctl function is used both for files and directories, but only the files support doing that in 32-bit compat mode. For consistency, add the same compat handler to the dir operations as well. Reviewed-by: "Yan, Zheng" <zyan@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- fs/ceph/dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index a8f429882249..7c060cb22aa3 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c @@ -1785,6 +1785,7 @@ const struct file_operations ceph_dir_fops = { .open = ceph_open, .release = ceph_release, .unlocked_ioctl = ceph_ioctl, + .compat_ioctl = ceph_ioctl, .fsync = ceph_fsync, .lock = ceph_lock, .flock = ceph_flock, -- 2.20.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 11/26] ceph: fix compat_ioctl for ceph_dir_operations 2019-04-16 20:19 ` [PATCH v3 11/26] ceph: fix compat_ioctl for ceph_dir_operations Arnd Bergmann @ 2019-04-17 21:23 ` Al Viro 2019-04-17 21:31 ` Arnd Bergmann 0 siblings, 1 reply; 3+ messages in thread From: Al Viro @ 2019-04-17 21:23 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-fsdevel, y2038, linux-kernel, Yan, Zheng, stable, Sage Weil, Ilya Dryomov, ceph-devel On Tue, Apr 16, 2019 at 10:19:49PM +0200, Arnd Bergmann wrote: > The ceph_ioctl function is used both for files and directories, but only > the files support doing that in 32-bit compat mode. > > For consistency, add the same compat handler to the dir operations > as well. > > Reviewed-by: "Yan, Zheng" <zyan@redhat.com> > Cc: stable@vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > fs/ceph/dir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c > index a8f429882249..7c060cb22aa3 100644 > --- a/fs/ceph/dir.c > +++ b/fs/ceph/dir.c > @@ -1785,6 +1785,7 @@ const struct file_operations ceph_dir_fops = { > .open = ceph_open, > .release = ceph_release, > .unlocked_ioctl = ceph_ioctl, > + .compat_ioctl = ceph_ioctl, Again, broken on s390 (and so's the ceph_file_ops, of course). It wants compat_ptr() applied to argument... ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 11/26] ceph: fix compat_ioctl for ceph_dir_operations 2019-04-17 21:23 ` Al Viro @ 2019-04-17 21:31 ` Arnd Bergmann 0 siblings, 0 replies; 3+ messages in thread From: Arnd Bergmann @ 2019-04-17 21:31 UTC (permalink / raw) To: Al Viro Cc: Linux FS-devel Mailing List, y2038 Mailman List, Linux Kernel Mailing List, Yan, Zheng, # 3.4.x, Sage Weil, Ilya Dryomov, ceph-devel On Wed, Apr 17, 2019 at 11:23 PM Al Viro <viro@zeniv.linux.org.uk> wrote: > > On Tue, Apr 16, 2019 at 10:19:49PM +0200, Arnd Bergmann wrote: > > The ceph_ioctl function is used both for files and directories, but only > > the files support doing that in 32-bit compat mode. > > > > For consistency, add the same compat handler to the dir operations > > as well. > > > > Reviewed-by: "Yan, Zheng" <zyan@redhat.com> > > Cc: stable@vger.kernel.org > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > fs/ceph/dir.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c > > index a8f429882249..7c060cb22aa3 100644 > > --- a/fs/ceph/dir.c > > +++ b/fs/ceph/dir.c > > @@ -1785,6 +1785,7 @@ const struct file_operations ceph_dir_fops = { > > .open = ceph_open, > > .release = ceph_release, > > .unlocked_ioctl = ceph_ioctl, > > + .compat_ioctl = ceph_ioctl, > > Again, broken on s390 (and so's the ceph_file_ops, of course). > It wants compat_ptr() applied to argument... This gets changed in a later patch, I intentionally left this one doing the same as ceph_file_fops so the patch can be backported if necessary, without also backporting the patch that adds compat_ptr_ioctl. Arnd ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-17 21:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190416202013.4034148-1-arnd@arndb.de>
2019-04-16 20:19 ` [PATCH v3 11/26] ceph: fix compat_ioctl for ceph_dir_operations Arnd Bergmann
2019-04-17 21:23 ` Al Viro
2019-04-17 21:31 ` Arnd Bergmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox