From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E395C10F0B for ; Thu, 18 Apr 2019 07:42:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 157882183E for ; Thu, 18 Apr 2019 07:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555573347; bh=eprmXRmM089+ZUXajd46U1fcjs0bZ5Yu160zjhkcXtU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KYJhsvFi9gsCQPmh1kSyWKdf6i8QEqJYr1evUTqcLwARvCkxUySPtDHf1pr9S8phQ ZZWYLy9qHMfe6v2wMRgsM6pFyljXlOLLX+kfHkJicvOcI0q9uAvW9mszwAt12T2IDD GBJpc6J5jkdy7/TOk72jsjMapgmMRODhD4DTo/eo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387971AbfDRHm0 (ORCPT ); Thu, 18 Apr 2019 03:42:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:51778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731317AbfDRHm0 (ORCPT ); Thu, 18 Apr 2019 03:42:26 -0400 Received: from localhost (unknown [178.227.254.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C35052183E; Thu, 18 Apr 2019 07:42:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555573345; bh=eprmXRmM089+ZUXajd46U1fcjs0bZ5Yu160zjhkcXtU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cxsNn4LhhPTiWwDZDp0pTk8NXcece4V6SONPiIL9ETHed5KIl2k6ouQTtmHM+C0D/ Hk3Ws1xKCMEM/fPN+BqUZwiW7645zE/sP1TiY39s6VMS3J7t8HIMGIhGIyWTcAveVi Z1pllxy337RbgrbSe2iKmvZUXUz4QbeVJT0u+wk8= Date: Thu, 18 Apr 2019 09:42:22 +0200 From: Greg KH To: Fuqian Huang Cc: Stable@vger.kernel.org Subject: Re: [PATCH 4.14] atm:idt77252: Fix a kernel address leakage in idt77252 Message-ID: <20190418074222.GA17393@kroah.com> References: <20190418071721.12666-1-huangfq.daxian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190418071721.12666-1-huangfq.daxian@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Apr 18, 2019 at 03:17:21PM +0800, Fuqian Huang wrote: > From: Fuqian Huang > > As there is still no hash for %p to print the address in linux 4.14, > the address of function idt77252_init will be printed to syslog. > Outputting kernel addresses will reveal the locations of kernel code > and data. This case is similar to CVE-2018-7273[1]. > > Also, there is no need to print the address of > function idt77252_init in idt77252_init. > Just remove the print statement. > > [1] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-7273 > > Cc: # v4.14+ > Signed-off-by: Fuqian Huang > --- > drivers/atm/idt77252.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c > index 47f3c4a..76e7736 100644 > --- a/drivers/atm/idt77252.c > +++ b/drivers/atm/idt77252.c > @@ -3743,8 +3743,6 @@ static int __init idt77252_init(void) > { > struct sk_buff *skb; > > - printk("%s: at %p\n", __func__, idt77252_init); If you look at commit ad67b74d2469 ("printk: hash addresses printed with %p"), I think you missed about 14000 other instances you need to fix up :) I suggest, if you really care about this issue in your 4.14-based kernel tree, that you just backport these pointer printk patches and be done with it. That's too big of a change to accept into the 4.14.y LTS kernel, but as the lifespan for 4.14.y running on a "general purpose" system is probably only a few more months at most, I would recomment just using 4.19.y instead as this isn't an issue at all there. thanks, greg k-h