From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B3B0C282DD for ; Thu, 18 Apr 2019 18:34:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FFC72064A for ; Thu, 18 Apr 2019 18:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555612491; bh=Wp9HFVpCPvkH0jPAss366Yc/j16eP2Ww9+UJdbU3oOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yl2ViAh9fDv3hIeSFzO8yldUFIf1oy2BF/2C4EJwabH+6jZs3Qq/AWknsMJAly38I KwZIo8Ej1moLvQoN+UTTzdAkWd+hQ2r5Fs/BCQQ/xIg9ifCFyRWbwXOcLBrzoX1Ga8 hG79/WrngVyigCkJHQKe7gTuXIT0bMUnb2vtyepg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389880AbfDRR6f (ORCPT ); Thu, 18 Apr 2019 13:58:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:52682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389833AbfDRR6b (ORCPT ); Thu, 18 Apr 2019 13:58:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3AAFA217FA; Thu, 18 Apr 2019 17:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555610310; bh=Wp9HFVpCPvkH0jPAss366Yc/j16eP2Ww9+UJdbU3oOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ffQkXKbdSxt+vo2vYfl6A72/9joejEgDOPub3O1sVrJnTPaexTsFcaLCryGmY9eRD Abr2aQPe77tZtG1qsPymW22L6oQdF+N3dK6Kr2HUvieGJfXJlj3YbP0rt4ZLAntQHW iz25l/0eFnDGzuTrHKw/mCNikjmf8kfFujU1SD+g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Vetter , Sean Paul , Dave Airlie , Sasha Levin Subject: [PATCH 4.19 012/110] drm/udl: use drm_gem_object_put_unlocked. Date: Thu, 18 Apr 2019 19:56:01 +0200 Message-Id: <20190418160438.571813202@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190418160437.484158340@linuxfoundation.org> References: <20190418160437.484158340@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 8f3b487685b2acf71b42bb30d68fd9271bec8695 ] When Daniel removed struct_mutex he didn't fix this call to the unlocked variant which is required since we no longer use struct mutex. This fixes a bunch of: WARNING: CPU: 4 PID: 1370 at drivers/gpu/drm/drm_gem.c:931 drm_gem_object_put+0x2b/0x30 [drm] Modules linked in: udl xt_CHECKSUM ipt_MASQUERADE tun bridge stp llc nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t> CPU: 4 PID: 1370 Comm: Xorg Not tainted 5.0.0+ #2 backtraces when you plug in a udl device. Fixes: ae358dacd217 (drm/udl: Get rid of dev->struct_mutex usage) Reviewed-by: Daniel Vetter Cc: Sean Paul Signed-off-by: Dave Airlie Signed-off-by: Sasha Levin --- drivers/gpu/drm/udl/udl_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c index d5a23295dd80..bb7b58407039 100644 --- a/drivers/gpu/drm/udl/udl_gem.c +++ b/drivers/gpu/drm/udl/udl_gem.c @@ -224,7 +224,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev, *offset = drm_vma_node_offset_addr(&gobj->base.vma_node); out: - drm_gem_object_put(&gobj->base); + drm_gem_object_put_unlocked(&gobj->base); unlock: mutex_unlock(&udl->gem_lock); return ret; -- 2.19.1