From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DATE_IN_PAST_12_24, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E69DAC282DF for ; Fri, 19 Apr 2019 18:33:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD2E9204EC for ; Fri, 19 Apr 2019 18:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555698838; bh=yDXHncgVifW99QBcZFlgmS2r9q3yjksnYANg2HHSY0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GeqPovoWca+rJ+lQzDSQytqd8jamsprAhoKCkhoJD6KbegOglMKG9kMPgT066iWop CsV2AKSjSllmU/ChKcZWoRyKbEeb4Bwydy+EwPViazQdu36Ec3VjSWglM236QDef3a +422SX2BKh+/bCjobBTRRhVVlKjzH8jEVbqWQnpU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbfDSSd5 (ORCPT ); Fri, 19 Apr 2019 14:33:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:53882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727663AbfDSS3Q (ORCPT ); Fri, 19 Apr 2019 14:29:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D87020869; Fri, 19 Apr 2019 08:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555662278; bh=yDXHncgVifW99QBcZFlgmS2r9q3yjksnYANg2HHSY0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AGWfQwsBzaE4awifCSVPG6wv8Sre7lEB1lSYFosD81lPpZ16dK2WvUA2PUgL9orxC oKFcck4g8s9NefcRRWkYY+LrYcr8v842Gk/0JPsL3FRi7HRVer3OE4hck8jrDxUDBR enFHeDu+BtSZ2CkttbSoF/61EHskLuexk0ZOVWzg= Date: Thu, 18 Apr 2019 21:18:32 +0200 From: Greg KH To: Taras Kondratiuk Cc: Sasha Levin , stable@vger.kernel.org, Miklos Szeredi , Amir Goldstein , xe-linux-external@cisco.com Subject: Re: [4.4] Follow up fixes for 3fe6e52f0626 ("ovl: override creds with the ones from the superblock mounter") Message-ID: <20190418191832.GA19119@kroah.com> References: <155553936546.6358.17971586625335516119@takondra-t460s> <20190418134612.GH435@sasha-vm> <155561157203.5780.9658522761344748705@takondra-t460s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155561157203.5780.9658522761344748705@takondra-t460s> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Apr 18, 2019 at 11:19:32AM -0700, Taras Kondratiuk wrote: > Quoting Sasha Levin (2019-04-18 06:46:12) > > On Wed, Apr 17, 2019 at 03:16:05PM -0700, Taras Kondratiuk wrote: > > >Upstream commit 3fe6e52f0626 ("ovl: override creds with the ones from > > >the superblock mounter") is present in v4.4.156 as 121b09d30d48. But the > > >patch has a few follow up fixes in upstream that also have to be applied > > >to 4.4: > > >d0e13f5bbe4b ("ovl: fix uid/gid when creating over whiteout") in v4.7-rc4 > > >8fc646b44385 ("ovl: fix random return value on mount") in v4.13-rc2 > > > > The 2nd patch does not apply cleanly and seems to depend on 1175b6b8d96 > > and 51f8f3c4e225. > > The context is slightly modified by 51f8f3c4e225, but it looks > irrelevant. The fix should be still valid, because err value can be set > to PTR_ERR(mnt) above and when prepare_creds() fails ovl_fill_super() > will return a random value of mnt pointer instead of a proper error > code. Can you provide a working backport please, so that it can be applied? thanks, greg k-h