From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FFA9C10F14 for ; Tue, 23 Apr 2019 11:43:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0896C21738 for ; Tue, 23 Apr 2019 11:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727648AbfDWLnB (ORCPT ); Tue, 23 Apr 2019 07:43:01 -0400 Received: from mga18.intel.com ([134.134.136.126]:29502 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726443AbfDWLnB (ORCPT ); Tue, 23 Apr 2019 07:43:01 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 04:43:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,385,1549958400"; d="scan'208";a="167101853" Received: from rafaelro-mobl4.amr.corp.intel.com (HELO localhost) ([10.249.45.214]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2019 04:42:59 -0700 Date: Tue, 23 Apr 2019 14:42:58 +0300 From: Jarkko Sakkinen To: Sasha Levin Cc: stable@vger.kernel.org, Yue Haibing Subject: Re: [PATCH] tpm: Fix the type of the return value in calc_tpm2_event_size() Message-ID: <20190423114210.GA4499@linux.intel.com> References: <20190417152420.18170-1-jarkko.sakkinen@linux.intel.com> <20190417163423.GD435@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190417163423.GD435@sasha-vm> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Apr 17, 2019 at 12:34:23PM -0400, Sasha Levin wrote: > On Wed, Apr 17, 2019 at 06:24:20PM +0300, Jarkko Sakkinen wrote: > > From: Yue Haibing > > > > commit 32312418625764cdf740890ac9c78ca26a6a9d24 upstream > > This is really commit b9d0a85d6b2e76630cfd4c475ee3af4109bfd87a upstream > (looks like James added his S-O-B which changed the commit hash). Oops, thanks, will be more careful next time. > > > calc_tpm2_event_size() has an invalid signature because > > it returns a 'size_t' where as its signature says that > > it returns 'int'. > > > > Cc: > > Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log") > > Suggested-by: Jarkko Sakkinen > > Signed-off-by: Yue Haibing > > Reviewed-by: Jarkko Sakkinen > > Signed-off-by: Jarkko Sakkinen > > I've queued it for 5.0, thanks! Thank you. /Jarkko