From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 210B7C10F03 for ; Tue, 23 Apr 2019 14:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB9222175B for ; Tue, 23 Apr 2019 14:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556031364; bh=kXHTwsMq35BoUfYzw4BlZVDnGpa36O3X4RmnI5TUAYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=DpKmdNtqXh6yENjRlu8qjWQbqo6wNx9U7XG6+iyr5IstqXeNlYrHWiJvMIbHFlCX5 YeY1xmgzTdPubBTVCBBur+lYA8zNOcmebYZAxwaeM9aZqSqyb7vvLPqFdxPLRyJdDW +jbVzR4ylIh9qo17gPsuUnR7q73ZBcnBJdvIlFn4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727737AbfDWO4D (ORCPT ); Tue, 23 Apr 2019 10:56:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:40500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727703AbfDWO4D (ORCPT ); Tue, 23 Apr 2019 10:56:03 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EF8521738; Tue, 23 Apr 2019 14:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556031362; bh=kXHTwsMq35BoUfYzw4BlZVDnGpa36O3X4RmnI5TUAYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hr6y62gpUu6imL/sE0T2yE6M6/hel3mzp/KQKSJvES0IT5E2M2qaca8qnibzcDOYs 7jIaPnSoYpTu1uWAom5CiLb439OM1rj8gDGcqDbknNzjRoqTSeNhuHLZSrDpTAWl4j fl5Ng1IQkzMV/E3zudXtRMRvDtGHAdmBNjYeM7wI= Date: Tue, 23 Apr 2019 10:56:01 -0400 From: Sasha Levin To: Nathan Chancellor Cc: Matthias Kaehlcke , stable@vger.kernel.org, Greg Kroah-Hartman , Nick Desaulniers , Masahiro Yamada Subject: Re: [Forw] [PATCH 1/2] modpost: file2alias: go back to simple devtable lookup Message-ID: <20190423145601.GM17719@sasha-vm> References: <20190422212239.GB112750@google.com> <20190423070832.GA20533@archlinux-i9> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190423070832.GA20533@archlinux-i9> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 23, 2019 at 12:08:32AM -0700, Nathan Chancellor wrote: >On Mon, Apr 22, 2019 at 02:22:39PM -0700, Matthias Kaehlcke wrote: >> Hi, >> >> recent clang version rightfully barf when they come across ADD_TO_DEVTABLE: >> >> scripts/mod/file2alias.c:1222:1: warning: adding 'unsigned long' to >> a string does not append to the string [-Wstring-plus-int] >> ADD_TO_DEVTABLE("mei", mei_cl_device_id, do_mei_entry); >> >> scripts/mod/file2alias.c:108:13: note: expanded from macro >> 'ADD_TO_DEVTABLE' >> device_id + 0*sizeof((function)((const char *)NULL, >> >> >> This can be addressed with the following upstream changes: >> >> f880eea68fe5 modpost: file2alias: check prototype of handler >> ec91e78d378c modpost: file2alias: go back to simple devtable lookup >> >> Could these be added to -stable? >> >> This affects all versions back to 4.4 (no clang support for older >> versions), though it's just a warning and the number of clang users >> with older kernels is probably fairly limited. >> > >[resending with Nick's correct email address] > >All of the clang commits have been backported to 4.4. It would be nice >to have these commits because that warning is very noisy. > >Note, this will not apply cleanly to 4.4, 4.9, and 4.14. I have attached >mbox files with the conflicts resolved, after build testing for arm64 >and x86_64. 4.19 is a clean cherry pick for me. > >Also added Masahiro to CC. I've queued all of these for 4.4-4.19, and they already exist in 5.0. Thanks all. -- Thanks, Sasha