From: Sasha Levin <sashal@kernel.org>
To: "Chang, Kaiyen" <kaiyen.chang@intel.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Subject: Re: [PATCH v1] mmc: sdhci: Handle auto-command errors
Date: Wed, 24 Apr 2019 08:58:15 -0400 [thread overview]
Message-ID: <20190424125815.GY17719@sasha-vm> (raw)
In-Reply-To: <C8CA9DD2F7F71D40AB24F31AA344356678D78A35@PGSMSX102.gar.corp.intel.com>
On Wed, Apr 24, 2019 at 02:55:31AM +0000, Chang, Kaiyen wrote:
>> -----Original Message-----
>> From: Sasha Levin [mailto:sashal@kernel.org]
>> Sent: Tuesday, April 23, 2019 9:43 PM
>> To: Chang, Kaiyen <kaiyen.chang@intel.com>
>> Cc: stable@vger.kernel.org; Hunter, Adrian <adrian.hunter@intel.com>;
>> ulf.hansson@linaro.org
>> Subject: Re: [PATCH v1] mmc: sdhci: Handle auto-command errors
>>
>> On Tue, Apr 23, 2019 at 04:50:58PM +0800, Kaiyen Chang wrote:
>> > Existing data command CRC error handling on kernel 4.20 stable branch
>> > is non-standard and does not work with some Intel host controllers.
>> > Specifically, the assumption that the host controller will continue
>> > operating normally after the error interrupt, is not valid. So we
>> > suggest cherry-pick the 3 patches listed below to kernel 4.20 stable
>> > branch, which can change the driver to handle the error in the same
>> > manner as a data CRC error.
>> >
>> > 4bf7809: mmc: sdhci: Fix data command CRC error handling
>> > 869f8a6: mmc: sdhci: Rename SDHCI_ACMD12_ERR and
>> SDHCI_INT_ACMD12ERR
>> > af849c8: mmc: sdhci: Handle auto-command errors
>> >
>> > All of the patches above have landed on kernel 5.0 stable branch.
>>
>> 4.20 went EoL quite a while ago, you should be using 5.0 at this point.
>>
>> I've queued these to older stable kernels, thanks.
>>
>> --
>> Thanks,
>> Sasha
>
>Hi Sasha,
>
>Actually our goal is to merge the 3 patches to 4.19.y and 4.14.y stable branch, however, I mistakenly believed that the patches should be present in 4.20.y first and did not notice that 4.20.y has been EOL. Sorry for that. Should I create another thread to issue the request for merging the 3 patches to 4.19.y and 4.14.y?
I've already queued it for 4.19 and 4.14, nothing else to do here.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-04-24 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 8:50 [PATCH v1] mmc: sdhci: Handle auto-command errors Kaiyen Chang
2019-04-23 12:34 ` Greg KH
2019-04-24 1:16 ` Chang, Kaiyen
2019-04-23 13:42 ` Sasha Levin
2019-04-24 2:55 ` Chang, Kaiyen
2019-04-24 12:58 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424125815.GY17719@sasha-vm \
--to=sashal@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=kaiyen.chang@intel.com \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).