From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62C31C10F11 for ; Wed, 24 Apr 2019 12:58:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3216621773 for ; Wed, 24 Apr 2019 12:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556110698; bh=+N834pBHa649EjtuH7xpp8X9cK+6qtpqc0KqEpMCt7Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KcbRsIKj1GIk6bhCox9DASggLFLwWbQfINAURHPeA0NWVSJjsNK5wKvU396lypMom TcVWngGVZvTp+5sdeD9U57mNC4Phyg0iFe3i0KhhsuWtjwmAiR93ac7KmBc5y1rBMj hPi0RK7jVUYJ+beq+4sFBKJfbGmVIDV+BgzHMjAU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727518AbfDXM6R (ORCPT ); Wed, 24 Apr 2019 08:58:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:56970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726322AbfDXM6R (ORCPT ); Wed, 24 Apr 2019 08:58:17 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E6F421773; Wed, 24 Apr 2019 12:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556110696; bh=+N834pBHa649EjtuH7xpp8X9cK+6qtpqc0KqEpMCt7Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uY0rCmYyPw3pDzbanIr+xnPMdT6ywGz6tabMsIQaczbZbMXHZ8S/mMCrxZ1MN8F4z LnkILK4HK/Lv4pOiXx5tFGfudFClhX7hh+xWshehg1W2U5KNq2DimkoD8WHSzT230T kHRbVcNeo1wOy89wE0PxPJ244dbFYbbp83/fmKXI= Date: Wed, 24 Apr 2019 08:58:15 -0400 From: Sasha Levin To: "Chang, Kaiyen" Cc: "stable@vger.kernel.org" , "Hunter, Adrian" , "ulf.hansson@linaro.org" Subject: Re: [PATCH v1] mmc: sdhci: Handle auto-command errors Message-ID: <20190424125815.GY17719@sasha-vm> References: <1556009458-23385-1-git-send-email-kaiyen.chang@intel.com> <20190423134253.GL17719@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Apr 24, 2019 at 02:55:31AM +0000, Chang, Kaiyen wrote: >> -----Original Message----- >> From: Sasha Levin [mailto:sashal@kernel.org] >> Sent: Tuesday, April 23, 2019 9:43 PM >> To: Chang, Kaiyen >> Cc: stable@vger.kernel.org; Hunter, Adrian ; >> ulf.hansson@linaro.org >> Subject: Re: [PATCH v1] mmc: sdhci: Handle auto-command errors >> >> On Tue, Apr 23, 2019 at 04:50:58PM +0800, Kaiyen Chang wrote: >> > Existing data command CRC error handling on kernel 4.20 stable branch >> > is non-standard and does not work with some Intel host controllers. >> > Specifically, the assumption that the host controller will continue >> > operating normally after the error interrupt, is not valid. So we >> > suggest cherry-pick the 3 patches listed below to kernel 4.20 stable >> > branch, which can change the driver to handle the error in the same >> > manner as a data CRC error. >> > >> > 4bf7809: mmc: sdhci: Fix data command CRC error handling >> > 869f8a6: mmc: sdhci: Rename SDHCI_ACMD12_ERR and >> SDHCI_INT_ACMD12ERR >> > af849c8: mmc: sdhci: Handle auto-command errors >> > >> > All of the patches above have landed on kernel 5.0 stable branch. >> >> 4.20 went EoL quite a while ago, you should be using 5.0 at this point. >> >> I've queued these to older stable kernels, thanks. >> >> -- >> Thanks, >> Sasha > >Hi Sasha, > >Actually our goal is to merge the 3 patches to 4.19.y and 4.14.y stable branch, however, I mistakenly believed that the patches should be present in 4.20.y first and did not notice that 4.20.y has been EOL. Sorry for that. Should I create another thread to issue the request for merging the 3 patches to 4.19.y and 4.14.y? I've already queued it for 4.19 and 4.14, nothing else to do here. -- Thanks, Sasha