From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84920C10F11 for ; Wed, 24 Apr 2019 16:48:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52268206A3 for ; Wed, 24 Apr 2019 16:48:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="fSlXWpJa"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="QFpg94i5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732529AbfDXQsR (ORCPT ); Wed, 24 Apr 2019 12:48:17 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42053 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726935AbfDXQsR (ORCPT ); Wed, 24 Apr 2019 12:48:17 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 90FB821BBE; Wed, 24 Apr 2019 12:48:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 24 Apr 2019 12:48:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=vIMDimYFNuzdS8ayGkJc8sgmE3I rnnbIlGYfO5PEQNw=; b=fSlXWpJaRrobAfpF9M3PFP5NJ1SFLhC/5pRB0mHi3Vp kdurS4BzV3V9LCaNuu+383eD3E80fwy1YoA6AohRV0fo4L4e5HoGQi1kVbdBPezz 6Dwo7T8ywe0Dhv5aeOv30C7o5ZbiHcD9laXsPDdZ26/nopo7qF+mp01CFk+EOCoJ S+7J8tK5WM0uylCMiZT05AEAxFm9RT53HRlJSedzMFVLC/Ebmab/ldtkUx+Ty+W4 bETBWYAWMuZHrM/CNZ/Ul4LdvG/QZhbDYSFRbh2LdWynxVV4tUPKkuLbN280K7lJ oK6BQN0ISUgQaUnPkDrGhYxF4yr0zUV7mqN9/SSQJog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=vIMDim YFNuzdS8ayGkJc8sgmE3IrnnbIlGYfO5PEQNw=; b=QFpg94i5iN5LKAa/ByHaEa CtyuMiK88Vcy6lkcaCtdki0p9COl9P266TVIdTjVVNc3dAf9pquryms+4bShD4Gt wcWceRy9rCpz8AkKX4mRNmZvfIsFhcRg3H6qmMQBhbe3sKCM9hY9k1ElRJzBb/FH 3puAL5pNaNU1k/4zgkPoSkgJvYhUS8s41WVnsAuPYmkyYtzJa6ytKZ7W2yxDRqBB BHSTMj2VeDs65tecA46KQhgjYy3u5eMaGDet2Td8BNGe1XCZ3NkJQElPcq1okGcL l+H9bSFsieTFclE6hfFeRDBBrx4R+Aos9JwFzcTTrOgVpxjBcl8mB1kNGQ+Sua/Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrhedvgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepiedvrdduleefrdehtddrvd dvleenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhmnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) by mail.messagingengine.com (Postfix) with ESMTPA id DCE9BE40E3; Wed, 24 Apr 2019 12:48:14 -0400 (EDT) Date: Wed, 24 Apr 2019 18:48:13 +0200 From: Greg KH To: Ming Lei Cc: Yi Zhang , Sagi Grimberg , Chaitanya Kulkarni , stable@vger.kernel.org, linux-nvme@lists.infradead.org, Christoph Hellwig Subject: Re: [RESEND PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Message-ID: <20190424164813.GD21916@kroah.com> References: <20190402015610.26320-1-ming.lei@redhat.com> <20190403140427.GD8633@kroah.com> <20190403162226.GA22741@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190403162226.GA22741@ming.t460p> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Apr 04, 2019 at 12:22:27AM +0800, Ming Lei wrote: > On Wed, Apr 03, 2019 at 04:04:27PM +0200, Greg KH wrote: > > On Tue, Apr 02, 2019 at 09:56:10AM +0800, Ming Lei wrote: > > > NVMe target only accepts single-page sg list, either file or block > > > device backed target code follows this assumption. > > > > > > However, loop target is one exception, given the sg list is from > > > the host queue directly. > > > > > > This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 > > > for following NVMe target assumption. > > > > > > Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36 > > > ("nvmet: fix building bvec from sg list") can fix the current issue > > > simply without needing to limit the segment size for nvme-loop. > > > > I don't understand, 02db99548d36 does not work for older kernels, so > > because of that, you need/want this patch to be applied? If so, what > > specific kernel versions do you want this to go to? > > Old kernel needs both this patch and 02db99548d36, and you should see > the description in 02db99548d36 commit log too. > > This patch should be needed since nvme-loop is introduced. I'm sorry, I still do not understand. Please resend the patches that you wish to have applied, with the proper git commit ids, and let us know what trees they should be applied to. I can not parse the above text, sorry. greg k-h