From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BFE8C10F11 for ; Wed, 24 Apr 2019 17:28:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF0DB21905 for ; Wed, 24 Apr 2019 17:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556126896; bh=Z38Q4RplQPvZdRj9T13BK59Dr2zpud/8AU35EjdsxFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PuA1Edz3EnAPlK339/6PDQNSiYpWfrHkZ9vxY2F+frML2kz6Bef1O5S1tj1+YMBkP eUfitSpdJ5LsQCDgqzS4Hv4lHcMQt/HHkfhlopXujN7R4vbw7acFaxbdYaw1L+5ev2 AnnGEvXY/11KYbm/A+UrVQ9VC5Z3te/iTij2a5Wg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390634AbfDXR2Q (ORCPT ); Wed, 24 Apr 2019 13:28:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:54470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389906AbfDXR2P (ORCPT ); Wed, 24 Apr 2019 13:28:15 -0400 Received: from localhost (62-193-50-229.as16211.net [62.193.50.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38DBE206BA; Wed, 24 Apr 2019 17:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556126894; bh=Z38Q4RplQPvZdRj9T13BK59Dr2zpud/8AU35EjdsxFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Df//gglSPjcUAg3eXRk1uqnS3JBZ+boM3K/S0WVJsZNS9F7WPfmu9aGpCoUjgH+ti dl+rBMSd31sAR4s02NDix/IGGYH9aJAq41ddLMUXEyz7YPsT66JspIapcXYGeYl0eZ 8sIWBhIEg575HVy4j1W+2HT7O32ZrGftl7NiY8TQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jarkko Sakkinen , Stefan Berger , Jerry Snitselaar , Sasha Levin Subject: [PATCH 4.14 54/70] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete Date: Wed, 24 Apr 2019 19:10:14 +0200 Message-Id: <20190424170917.424006942@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190424170906.751869122@linuxfoundation.org> References: <20190424170906.751869122@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 442601e87a4769a8daba4976ec3afa5222ca211d ] Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour. Cc: stable@vger.kernel.org Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs") Signed-off-by: Jarkko Sakkinen Reviewed-by: Stefan Berger Reviewed-by: Jerry Snitselaar Signed-off-by: Sasha Levin --- drivers/char/tpm/tpm_i2c_atmel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c index 32a8e27c5382..cc4e642d3180 100644 --- a/drivers/char/tpm/tpm_i2c_atmel.c +++ b/drivers/char/tpm/tpm_i2c_atmel.c @@ -69,6 +69,10 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len) if (status < 0) return status; + /* The upper layer does not support incomplete sends. */ + if (status != len) + return -E2BIG; + return 0; } -- 2.19.1