From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDF52C43219 for ; Tue, 30 Apr 2019 11:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D7E02173E for ; Tue, 30 Apr 2019 11:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556624512; bh=5SHsypmo8pe7K626t53+E/hpSpGB6teWcfIps7w6rIs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2UnN2bpRKN5IWrEIphRq2hW5QOXReyuJYVUxm6xMpY0dlYWAA/haCRNW2YiEm8xu5 Ep+Fu6TL1GP8b6um3UrWR4UMQQ1fbRwkMDy+nijxyotNYxWdgZqxt0VhqiYE3m6hWa B2DoFcqfXXIhCMkTV+iGXdbrBETV/04Ysfp1UvDQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729058AbfD3Llv (ORCPT ); Tue, 30 Apr 2019 07:41:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:49956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729036AbfD3Lls (ORCPT ); Tue, 30 Apr 2019 07:41:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29B1121670; Tue, 30 Apr 2019 11:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556624507; bh=5SHsypmo8pe7K626t53+E/hpSpGB6teWcfIps7w6rIs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tqg8WQDiu4YTFPDe3w71ewj2VlBmfSMNJw5FK+XytJF8xZdxHaSndHJh/hP8Ee1rW qEopSnJw7F41nxCRH23WC1vUQ943KtNVhZ8PsEDWfC9XTrPypzsx4DURoq8euHDFCZ m5BSyDl+RKj1TSIWRrvfAfaXsVVvvV4GvMc5EtZk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Frank Sorenson , Steve French , Ronnie Sahlberg Subject: [PATCH 4.14 02/53] cifs: do not attempt cifs operation on smb2+ rename error Date: Tue, 30 Apr 2019 13:38:09 +0200 Message-Id: <20190430113549.852405340@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430113549.400132183@linuxfoundation.org> References: <20190430113549.400132183@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Frank Sorenson commit 652727bbe1b17993636346716ae5867627793647 upstream. A path-based rename returning EBUSY will incorrectly try opening the file with a cifs (NT Create AndX) operation on an smb2+ mount, which causes the server to force a session close. If the mount is smb2+, skip the fallback. Signed-off-by: Frank Sorenson Signed-off-by: Steve French CC: Stable Reviewed-by: Ronnie Sahlberg Signed-off-by: Greg Kroah-Hartman --- fs/cifs/inode.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -1730,6 +1730,10 @@ cifs_do_rename(const unsigned int xid, s if (rc == 0 || rc != -EBUSY) goto do_rename_exit; + /* Don't fall back to using SMB on SMB 2+ mount */ + if (server->vals->protocol_id != 0) + goto do_rename_exit; + /* open-file renames don't work across directories */ if (to_dentry->d_parent != from_dentry->d_parent) goto do_rename_exit;