From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924C3C43219 for ; Thu, 2 May 2019 12:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55E192089E for ; Thu, 2 May 2019 12:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556801811; bh=yj300TW+fJqT6K6BSGF2jtEG/Xt4a4FDcEA/4LmZcjs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VdhP9VGlRSvIluz/s5FvUp7vQ4soRRw2/cszBlo07B/BWj2f+NWU48ZQeOi29HAjC YUbgRTitdODJPP3FMcZ6S7TTk8dNEfTxv2HmAWtjCzWFQbYf3MhAwJeC2zAWN3tcmj oWN2blDjJhHLpSLTS4kjli+HaSeM+swpWnOpfUVM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726324AbfEBM4u (ORCPT ); Thu, 2 May 2019 08:56:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:35940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbfEBM4u (ORCPT ); Thu, 2 May 2019 08:56:50 -0400 Received: from localhost (adsl-173-228-226-134.prtc.net [173.228.226.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39FB420449; Thu, 2 May 2019 12:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556801809; bh=yj300TW+fJqT6K6BSGF2jtEG/Xt4a4FDcEA/4LmZcjs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N1CNu64DdNDI6n6Pd4zvz/PjlpDiFGriUxmGgT0/aEEIlVYPNO5MpTGqG7iTelmKQ JozEqiBnuNmR0hNLn0yOAQTnPD5zKtk6yBqYPUuJl8FJoyUq8mFmzKss3kpaJ/vgJM 2NV/TrbxUU0gmrBBPMtprJNCOepEvFx6dTFGe1Ek= Date: Thu, 2 May 2019 08:50:01 -0400 From: Sasha Levin To: Suzuki K Poulose Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, yuzenghui@huawei.com, christoffer.dall@arm.com, marc.zyngier@arm.com, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH AUTOSEL 5.0 29/98] KVM: arm/arm64: Enforce PTE mappings at stage2 when needed Message-ID: <20190502125001.GB11584@sasha-vm> References: <20190422194205.10404-1-sashal@kernel.org> <20190422194205.10404-29-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 23, 2019 at 10:27:26AM +0100, Suzuki K Poulose wrote: >Hi Sasha, > >On 04/22/2019 08:40 PM, Sasha Levin wrote: >>From: Suzuki K Poulose >> >>[ Upstream commit a80868f398554842b14d07060012c06efb57c456 ] >> >>commit 6794ad5443a2118 ("KVM: arm/arm64: Fix unintended stage 2 PMD mappings") >>made the checks to skip huge mappings, stricter. However it introduced >>a bug where we still use huge mappings, ignoring the flag to >>use PTE mappings, by not reseting the vma_pagesize to PAGE_SIZE. >> >>Also, the checks do not cover the PUD huge pages, that was >>under review during the same period. This patch fixes both >>the issues. >> >>Fixes : 6794ad5443a2118 ("KVM: arm/arm64: Fix unintended stage 2 PMD mappings") >>Reported-by: Zenghui Yu >>Cc: Zenghui Yu >>Cc: Christoffer Dall >>Signed-off-by: Suzuki K Poulose >>Signed-off-by: Marc Zyngier >>Signed-off-by: Sasha Levin (Microsoft) > >Please be aware that we need a follow up fix for this patch to fix the >problem for THP backed memory. > >http://lists.infradead.org/pipermail/linux-arm-kernel/2019-April/645324.html > > >It should appear upstream soon. Since it's not upstream yet, I'll drop this patch for now and queue it for a later release. -- Thanks, Sasha