From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF5DC04AA9 for ; Thu, 2 May 2019 15:45:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9C22205C9 for ; Thu, 2 May 2019 15:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811955; bh=b1UvfmrvpCR8JsMQMbD1yux55WKT5xNT1ZAn3vdREG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iTQuwmy/z1oR+csTUrOzitLO5e1aE+pTeHWhwmZ/EvzUBsDUpPxgW18SxpaTKEEKa 1CXaEZDNidvrK981ikNxUjAFKOqgRV6uWwzLQcz2YaM5vCP6fnDkGxE+Oj1+w7/lAh m7ZEpq/5a3A0NZMXoMPxDpEYhCOXrWyiTdKtoHL4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727399AbfEBPpr (ORCPT ); Thu, 2 May 2019 11:45:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:41818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727558AbfEBPZa (ORCPT ); Thu, 2 May 2019 11:25:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CEEE920B7C; Thu, 2 May 2019 15:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556810730; bh=b1UvfmrvpCR8JsMQMbD1yux55WKT5xNT1ZAn3vdREG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yQ56z+v6DGbW3o54jbG0BzKSV8fxkc5mTiAvZ6EXy40cNEL2vLB8OYx478umbza6K mgcTWOkR5om3Nb7CtvnXzaMm9K1f3Vtc0VpEWYAW2swmd0s3bsu+KEe4pvNNTCb3dB xR/X8At3uPf3Lq8V1tCrZj0OSLSoa/9VGrPpAmdA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aditya Pakki , Mukesh Ojha , "Sasha Levin (Microsoft)" Subject: [PATCH 4.14 28/49] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc Date: Thu, 2 May 2019 17:21:05 +0200 Message-Id: <20190502143327.408000450@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143323.397051088@linuxfoundation.org> References: <20190502143323.397051088@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 6a8ca24590a2136921439b376c926c11a6effc0e ] phydm.internal is allocated using kzalloc which is used multiple times without a check for NULL pointer. This patch avoids such a scenario by returning 0, consistent with the failure case. Signed-off-by: Aditya Pakki Reviewed-by: Mukesh Ojha Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin (Microsoft) --- drivers/staging/rtlwifi/phydm/rtl_phydm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtlwifi/phydm/rtl_phydm.c b/drivers/staging/rtlwifi/phydm/rtl_phydm.c index 85e490d3601f..cab563fefc34 100644 --- a/drivers/staging/rtlwifi/phydm/rtl_phydm.c +++ b/drivers/staging/rtlwifi/phydm/rtl_phydm.c @@ -191,6 +191,8 @@ static int rtl_phydm_init_priv(struct rtl_priv *rtlpriv, rtlpriv->phydm.internal = kzalloc(sizeof(struct phy_dm_struct), GFP_KERNEL); + if (!rtlpriv->phydm.internal) + return 0; _rtl_phydm_init_com_info(rtlpriv, ic, params); -- 2.19.1