From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85534C43219 for ; Thu, 2 May 2019 15:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CB7E204EC for ; Thu, 2 May 2019 15:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811970; bh=Z5Q3p7tnXJAzzJtZccMCQ5DxuI62SO5FeHj3JdloG34=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=h0SmSx5el4gbT7FgyYgKtELwo4t0d9FoltegD5EPVjc5kYEHkPxJv0fh5pW2H3q/1 LGLSPbP3bnLNGysuyLyCAo+4nzUC5eLaWR23KChL+E8Byays9x+uwo5pRhPuTXWPkm BGsNd6VREaaBBxUOOGmvvpcFJloeNYvve0Ivyaws= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727524AbfEBPZY (ORCPT ); Thu, 2 May 2019 11:25:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:41560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727018AbfEBPZU (ORCPT ); Thu, 2 May 2019 11:25:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7048721670; Thu, 2 May 2019 15:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556810719; bh=Z5Q3p7tnXJAzzJtZccMCQ5DxuI62SO5FeHj3JdloG34=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fyYyp0SYzq0tVgU0CXTUZF5HnZRd7fxhFu+pZ+LGQ2mFSzEx+TidUUcaXhHGoeHF+ 9gj3Jnxwth9wvQxzWofD/IP/iOH7vJ/h4l8BZP+DhmpMermkUb0aNxg0TbAKjpfABK VcZpCTNQOz+5OkUeDSapeYElF4AdoLMCNslmUqTo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Yang , Douglas Miller , "David S. Miller" , netdev@vger.kernel.org, "Sasha Levin (Microsoft)" Subject: [PATCH 4.14 34/49] net: ibm: fix possible object reference leak Date: Thu, 2 May 2019 17:21:11 +0200 Message-Id: <20190502143328.133935883@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143323.397051088@linuxfoundation.org> References: <20190502143323.397051088@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit be693df3cf9dd113ff1d2c0d8150199efdba37f6 ] The call to ehea_get_eth_dn returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/net/ethernet/ibm/ehea/ehea_main.c:3163:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3154, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Douglas Miller Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 4878b7169e0f..30cbdf0fed59 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -3176,6 +3176,7 @@ static ssize_t ehea_probe_port(struct device *dev, if (ehea_add_adapter_mr(adapter)) { pr_err("creating MR failed\n"); + of_node_put(eth_dn); return -EIO; } -- 2.19.1