From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E497EC04AAA for ; Thu, 2 May 2019 15:24:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3153214DA for ; Thu, 2 May 2019 15:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556810690; bh=CpTTlyy91+cNn24bTlrJNVNglI7TrQXbypdEalzcWxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0Wo1CX08lExtufRcVOUsG+ry2mBvG6apy0zXlBuEMsmJ9hiGu5GzTGmkhD1Qva1Aq CzwCSGGX+If+cz6lkb2tXjO41XiXKkx2quj/zhJgXe8KVhMy2CDDl45NJ3NBmBgrvu 7yV4jCHAM2dot9UGTDH/HdgzJ4McI0rr4ZmWNAFI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727385AbfEBPYu (ORCPT ); Thu, 2 May 2019 11:24:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:40788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726812AbfEBPYt (ORCPT ); Thu, 2 May 2019 11:24:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15EEA2085A; Thu, 2 May 2019 15:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556810688; bh=CpTTlyy91+cNn24bTlrJNVNglI7TrQXbypdEalzcWxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ScrWuzQvJxoy6ruEJKT5WjynDjX7o6ocG5AnXsf99dhC2xNfiDwofzCdBwpVSPGAr f8mBKSP28COt3eKWUQCMT2RhV4LEKRk2yflOLdKtW8oz+kGQ5inIMHwz+SSGUT3uKE w3GXQ0gHJ5AAfaVSWCGXILcZoDC6s9cBGg1rKOcE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Al Viro , Jeff Layton , Ilya Dryomov , "Sasha Levin (Microsoft)" Subject: [PATCH 4.14 42/49] ceph: fix use-after-free on symlink traversal Date: Thu, 2 May 2019 17:21:19 +0200 Message-Id: <20190502143329.246792108@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143323.397051088@linuxfoundation.org> References: <20190502143323.397051088@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit daf5cc27eed99afdea8d96e71b89ba41f5406ef6 ] free the symlink body after the same RCU delay we have for freeing the struct inode itself, so that traversal during RCU pathwalk wouldn't step into freed memory. Signed-off-by: Al Viro Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin (Microsoft) --- fs/ceph/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index a1492bdc6d03..f2b722f0df5d 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -520,6 +520,7 @@ static void ceph_i_callback(struct rcu_head *head) struct inode *inode = container_of(head, struct inode, i_rcu); struct ceph_inode_info *ci = ceph_inode(inode); + kfree(ci->i_symlink); kmem_cache_free(ceph_inode_cachep, ci); } @@ -551,7 +552,6 @@ void ceph_destroy_inode(struct inode *inode) ceph_put_snap_realm(mdsc, realm); } - kfree(ci->i_symlink); while ((n = rb_first(&ci->i_fragtree)) != NULL) { frag = rb_entry(n, struct ceph_inode_frag, node); rb_erase(n, &ci->i_fragtree); -- 2.19.1