From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F616C04AAA for ; Thu, 2 May 2019 15:44:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35E1E204FD for ; Thu, 2 May 2019 15:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556811874; bh=WJN5iWIvcgKpaO/zBux1NJbNQ6G/V7nfw02+h+bfIvI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GWhLJufcuEQiSomelRDBaLE4lxzF3OznbWo/J7SBO0+wOSLPDLtg+Q9TMYT5FJj77 l0nwT+YeXRy87SjeMrYz0egwZIun1kvPJ+woSPVVecJmp3Xwo9azQd+7ILzHmWtkVc fG1szuvHwvKWDvbH9YqMbYKMvrLmq44crZ8NGGWM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726928AbfEBPod (ORCPT ); Thu, 2 May 2019 11:44:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:43162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726976AbfEBP03 (ORCPT ); Thu, 2 May 2019 11:26:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5630120449; Thu, 2 May 2019 15:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556810788; bh=WJN5iWIvcgKpaO/zBux1NJbNQ6G/V7nfw02+h+bfIvI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LcPq7Z0bAgky1CfcofTyjiHiCc37UAB6Lf3/zZXpXKANDCiM+D1fMuhVEyD+ey1Uo VKVBrRT+Do9zh1I9f+TvRkESNMq80+SLHz+xZ1Y0G0ziaD4+fTSrV0euZeGsO1O1SH VXNHEkz7Hcevl/aaz+WUAWGNByknepSpeRLop4lc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aditya Pakki , "David S. Miller" , "Sasha Levin (Microsoft)" Subject: [PATCH 4.19 12/72] qlcnic: Avoid potential NULL pointer dereference Date: Thu, 2 May 2019 17:20:34 +0200 Message-Id: <20190502143334.402515249@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143333.437607839@linuxfoundation.org> References: <20190502143333.437607839@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 5bf7295fe34a5251b1d241b9736af4697b590670 ] netdev_alloc_skb can fail and return a NULL pointer which is dereferenced without a check. The patch avoids such a scenario. Signed-off-by: Aditya Pakki Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index 3b0adda7cc9c..a4cd6f2cfb86 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1048,6 +1048,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) { skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE); + if (!skb) + break; qlcnic_create_loopback_buff(skb->data, adapter->mac_addr); skb_put(skb, QLCNIC_ILB_PKT_SIZE); adapter->ahw->diag_cnt = 0; -- 2.19.1