From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE6A1C04AAA for ; Thu, 2 May 2019 15:28:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5BA321848 for ; Thu, 2 May 2019 15:28:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556810915; bh=OKWW1NpaEeMCeadV9HqRXT3LOx7/fe1pZjE/IXOKImY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AT30WFIC9YTH3hYu+49gxGsJi7W0E0S/ZiUOvhIubrf0ZoUlOnBch1PID2Ys/HOId 0gHvhbdevh1aHsAylre2ZuIN42aISi64hILNIENzLNaR3Ig1M0b7g3776KdBILdmWH ZmqeSw/xEFQMV/b8sho7bV6jCH+mdclAB7Efihus= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728210AbfEBP2e (ORCPT ); Thu, 2 May 2019 11:28:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:45814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728251AbfEBP2e (ORCPT ); Thu, 2 May 2019 11:28:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6899820449; Thu, 2 May 2019 15:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556810913; bh=OKWW1NpaEeMCeadV9HqRXT3LOx7/fe1pZjE/IXOKImY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xxheo7SuljQhPi/olpCjLW11rmv6wYc1ncyqFQt1NsNvp05nHj1XcePqlYwN2ONlt Fw0Dk5Qh70c6F4IcJbVnbf4Enk8NW3PZ+g/miaPWcWyGLljp/6Vcq+g1FqPwAKX4gq gM30FlbOvOEgOals1dxwkjl1DQd9ZGRVyGxMy0+4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Manish Rangankar , Mukesh Ojha , "Martin K. Petersen" , "Sasha Levin (Microsoft)" Subject: [PATCH 4.19 56/72] scsi: qla4xxx: fix a potential NULL pointer dereference Date: Thu, 2 May 2019 17:21:18 +0200 Message-Id: <20190502143337.820162639@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190502143333.437607839@linuxfoundation.org> References: <20190502143333.437607839@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6 ] In case iscsi_lookup_endpoint fails, the fix returns -EINVAL to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Acked-by: Manish Rangankar Reviewed-by: Mukesh Ojha Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin (Microsoft) --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 575445c761b4..5dd3e4e01b10 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -3204,6 +3204,8 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session, if (iscsi_conn_bind(cls_session, cls_conn, is_leading)) return -EINVAL; ep = iscsi_lookup_endpoint(transport_fd); + if (!ep) + return -EINVAL; conn = cls_conn->dd_data; qla_conn = conn->dd_data; qla_conn->qla_ep = ep->dd_data; -- 2.19.1