From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6BCC04AAD for ; Mon, 6 May 2019 15:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C92662053B for ; Mon, 6 May 2019 15:01:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557154908; bh=PP62qLmgfDJlZIPrBq8eayt1MJXDMqv4avsrry8kdIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=k9DEnGbZ5S3xB31wuGU9dDY6TzM94F53TR8hKh7SiZnbcSEglGYLNSZ1fx0RYrweI fOdT7IbM7CdzlqNKYsqj+uCmA9hiXmHEm+mcaRr3CC1wUF60GivkXcKlY11QOgvUkD 3q15ykPJO8ODSkN/DQwXbqZtcWlN2J1eePGiT3EE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728114AbfEFOlC (ORCPT ); Mon, 6 May 2019 10:41:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:34698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728126AbfEFOk7 (ORCPT ); Mon, 6 May 2019 10:40:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9ED282087F; Mon, 6 May 2019 14:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557153659; bh=PP62qLmgfDJlZIPrBq8eayt1MJXDMqv4avsrry8kdIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=db+J6ys5FQf76tdqSuCKrhwodspuMi08k2WVt4yKV9N6GWgtImFGnYCD/WCnAmGnB o2SI9igzBaWhmqHQ0lsMCrONn1AspM3Za2C06XhqZXprIz2ntCRcrrLMkP3tlJ4WOc s0Fi2qREnPDf/rxatb6FYMByhQxUoHA1M6Yiqn5I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wolfram Sang , Geert Uytterhoeven , Steve Twiss , Alexandre Belloni , Sasha Levin Subject: [PATCH 4.19 48/99] rtc: da9063: set uie_unsupported when relevant Date: Mon, 6 May 2019 16:32:21 +0200 Message-Id: <20190506143058.410177007@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143053.899356316@linuxfoundation.org> References: <20190506143053.899356316@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 882c5e552ffd06856de42261460f46e18319d259 ] The DA9063AD doesn't support alarms on any seconds and its granularity is the minute. Set uie_unsupported in that case. Reported-by: Wolfram Sang Reported-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang Acked-by: Steve Twiss Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-da9063.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c index b4e054c64bad..69b54e5556c0 100644 --- a/drivers/rtc/rtc-da9063.c +++ b/drivers/rtc/rtc-da9063.c @@ -480,6 +480,13 @@ static int da9063_rtc_probe(struct platform_device *pdev) da9063_data_to_tm(data, &rtc->alarm_time, rtc); rtc->rtc_sync = false; + /* + * TODO: some models have alarms on a minute boundary but still support + * real hardware interrupts. Add this once the core supports it. + */ + if (config->rtc_data_start != RTC_SEC) + rtc->rtc_dev->uie_unsupported = 1; + irq_alarm = platform_get_irq_byname(pdev, "ALARM"); ret = devm_request_threaded_irq(&pdev->dev, irq_alarm, NULL, da9063_alarm_event, -- 2.20.1