From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8874CC04AAD for ; Mon, 6 May 2019 14:55:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 523712054F for ; Mon, 6 May 2019 14:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557154514; bh=aiLjpeAoWNOBxt8nJ1mTSVl7fDXJwwZi5qiMMPi0HfA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yuL/Zaq2u31LPTVemZa1KpoRu/1MC2z23Jpw/rRU05nMn9S+xiF/zWyPmNlMGbb/c hu0uNWYxh1j05rOQRlnH0H9DcobevgnYmp9YBK0357q4bIPu7leVklEouHMkHRX8Wm IuPGzVVlXQPniL7Ube7LyFvAMyI4jjyJ5JNC2A34= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728614AbfEFOqN (ORCPT ); Mon, 6 May 2019 10:46:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:43834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728809AbfEFOqM (ORCPT ); Mon, 6 May 2019 10:46:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A76ED214C6; Mon, 6 May 2019 14:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557153972; bh=aiLjpeAoWNOBxt8nJ1mTSVl7fDXJwwZi5qiMMPi0HfA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TSWk26VbvMBE9maZls5DwVO1ttONkTC73zQcXtvN7C+Umf/tz2Ed2d8/gmA+Inx24 c8xbxX9/0QXgdIdfdUxzmP/R0qujqR5VQ7DnNzHIw7bG48GfDkGDOjXxgSYBT2k+Fn 8jeeZO0ossFsfTNcqmedlafzXj0pHUCedWWKABX8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Jurgens , Parav Pandit , Leon Romanovsky , Jason Gunthorpe Subject: [PATCH 4.14 65/75] IB/core: Unregister notifier before freeing MAD security Date: Mon, 6 May 2019 16:33:13 +0200 Message-Id: <20190506143059.149974388@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143053.287515952@linuxfoundation.org> References: <20190506143053.287515952@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Daniel Jurgens commit d60667fc398ed34b3c7456b020481c55c760e503 upstream. If the notifier runs after the security context is freed an access of freed memory can occur. Fixes: 47a2b338fe63 ("IB/core: Enforce security on management datagrams") Signed-off-by: Daniel Jurgens Reviewed-by: Parav Pandit Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/core/security.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/infiniband/core/security.c +++ b/drivers/infiniband/core/security.c @@ -732,9 +732,10 @@ void ib_mad_agent_security_cleanup(struc if (!rdma_protocol_ib(agent->device, agent->port_num)) return; - security_ib_free_security(agent->security); if (agent->lsm_nb_reg) unregister_lsm_notifier(&agent->lsm_nb); + + security_ib_free_security(agent->security); } int ib_mad_enforce_security(struct ib_mad_agent_private *map, u16 pkey_index)