From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E43FFC04A6B for ; Mon, 6 May 2019 15:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6B532053B for ; Mon, 6 May 2019 15:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557154849; bh=XHfRqNPamAIh+JBrPyP1AVVMI9BBXbcniQkJsMVsSHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wQHZ3eMDgd1ZCsjNqBQpD2LZ032uSeNORaaiwdQYCwfrNNS+c7/jdUNyJ4sg/8HQj +vAXAWuisWcd3RiVrpUVGgIqzmDrL+lZB1W4oFTLzrZXmUUouKfI4OabEnh3OQZ5/1 WkwecbdS93VR/L8LEgJD/L6OC0zuKUguEHWUEUeM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728380AbfEFOmA (ORCPT ); Mon, 6 May 2019 10:42:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:36454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728369AbfEFOl7 (ORCPT ); Mon, 6 May 2019 10:41:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69BD521479; Mon, 6 May 2019 14:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557153718; bh=XHfRqNPamAIh+JBrPyP1AVVMI9BBXbcniQkJsMVsSHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=id0u6tFkxAx06jhSzr3fwtHpExRzjmu1WsOuTziCbzF40TAnQHXVRDTnDKU7N8O1R Kqr5GCBlXOTlPoyRMyfGFTGAWgPSS7yXRCpmYLYM4OqwsFuQi4lYzPA3Y4CIzPhecl utSqsKjmyIuRw9DNLEJ95Xy+nHWfRphmhZhgbooA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Brian Norris , Matthias Kaehlcke , Linus Torvalds Subject: [PATCH 4.19 71/99] Bluetooth: btusb: request wake pin with NOAUTOEN Date: Mon, 6 May 2019 16:32:44 +0200 Message-Id: <20190506143100.581802215@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143053.899356316@linuxfoundation.org> References: <20190506143053.899356316@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Brian Norris commit 771acc7e4a6e5dba779cb1a7fd851a164bc81033 upstream. Badly-designed systems might have (for example) active-high wake pins that default to high (e.g., because of external pull ups) until they have an active firmware which starts driving it low. This can cause an interrupt storm in the time between request_irq() and disable_irq(). We don't support shared interrupts here, so let's just pre-configure the interrupt to avoid auto-enabling it. Fixes: fd913ef7ce61 ("Bluetooth: btusb: Add out-of-band wakeup support") Fixes: 5364a0b4f4be ("arm64: dts: rockchip: move QCA6174A wakeup pin into its USB node") Signed-off-by: Brian Norris Reviewed-by: Matthias Kaehlcke Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- drivers/bluetooth/btusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2888,6 +2888,7 @@ static int btusb_config_oob_wake(struct return 0; } + irq_set_status_flags(irq, IRQ_NOAUTOEN); ret = devm_request_irq(&hdev->dev, irq, btusb_oob_wake_handler, 0, "OOB Wake-on-BT", data); if (ret) { @@ -2902,7 +2903,6 @@ static int btusb_config_oob_wake(struct } data->oob_wake_irq = irq; - disable_irq(irq); bt_dev_info(hdev, "OOB Wake-on-BT configured at IRQ %u", irq); return 0; }