From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B614C04A6B for ; Mon, 6 May 2019 15:08:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8D252053B for ; Mon, 6 May 2019 15:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557155313; bh=nGmKw7oEcz7t/3WCPMGsy5WKp48TzXsV/M5wENwuxF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZVA8UPbfFiQoQfJJsGsB9oPYrAt5dmkgjp5I1xuoNIHD6x0v0YvxeM665/+GQwHG+ 6LMnRZHV2Y6G2M0IQJXq17Y7y8CQ/cRgo/DEUy38xr5EKT56aVYAkJrfg+33WNtlSl r3V64szvHlJH9Oe6DUjjLHtKzPnwskKTzXybCvSU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727110AbfEFOgR (ORCPT ); Mon, 6 May 2019 10:36:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:56598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727127AbfEFOgQ (ORCPT ); Mon, 6 May 2019 10:36:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6896E20C01; Mon, 6 May 2019 14:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557153375; bh=nGmKw7oEcz7t/3WCPMGsy5WKp48TzXsV/M5wENwuxF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=epVBLkrigMyU8yd/rTfWbJCp237oS4STsAq4ZX5V8ZENfpdf4SG5DA82CT59ptYT9 OSeLHIrs1vIZNlmmhIWt1/xVWEcQiSFh/dGrsBJqCDGzvd2u4ZWQKJILrnMcWSHedf rg/E02vx2jUYUO/H1LBQ7Q7xG5pTSwN9RzszJbqU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mukesh Ojha , Peng Hao , Ludovic Desroches , "Sasha Levin (Microsoft)" Subject: [PATCH 5.0 065/122] arm/mach-at91/pm : fix possible object reference leak Date: Mon, 6 May 2019 16:32:03 +0200 Message-Id: <20190506143100.794247114@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143054.670334917@linuxfoundation.org> References: <20190506143054.670334917@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit ba5e60c9b75dec92d4c695b928f69300b17d7686 ] of_find_device_by_node() takes a reference to the struct device when it finds a match via get_device. When returning error we should call put_device. Reviewed-by: Mukesh Ojha Signed-off-by: Peng Hao Signed-off-by: Ludovic Desroches Signed-off-by: Sasha Levin (Microsoft) --- arch/arm/mach-at91/pm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 51e808adb00c..2a757dcaa1a5 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c @@ -591,13 +591,13 @@ static int __init at91_pm_backup_init(void) np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam"); if (!np) - goto securam_fail; + goto securam_fail_no_ref_dev; pdev = of_find_device_by_node(np); of_node_put(np); if (!pdev) { pr_warn("%s: failed to find securam device!\n", __func__); - goto securam_fail; + goto securam_fail_no_ref_dev; } sram_pool = gen_pool_get(&pdev->dev, NULL); @@ -620,6 +620,8 @@ static int __init at91_pm_backup_init(void) return 0; securam_fail: + put_device(&pdev->dev); +securam_fail_no_ref_dev: iounmap(pm_data.sfrbu); pm_data.sfrbu = NULL; return ret; -- 2.20.1