From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C93C04AAD for ; Mon, 6 May 2019 15:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1E672053B for ; Mon, 6 May 2019 15:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557154823; bh=NPJ3DpwJTS2Oi6ThWQAWVDa3v0iLtAEYsoJkBu8Lgrs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ACWV0n2YSH47oixhrcHMWkiaac/ugKPkOtB3Q1tJJ411wZTmoHdbQ+hNvEffvV+jM 3LEk+ZH1FMfhx1KzHlHhdzPAbGVr2nmuaVssOCIBUiLDoCL3on4Otg3OCOrzozR0/x lJz81f5Uwvg+s+GibrWOD5HFosy6DrT8ZkFMy9JE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726567AbfEFPAX (ORCPT ); Mon, 6 May 2019 11:00:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:36984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727684AbfEFOmR (ORCPT ); Mon, 6 May 2019 10:42:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A80C021019; Mon, 6 May 2019 14:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557153737; bh=NPJ3DpwJTS2Oi6ThWQAWVDa3v0iLtAEYsoJkBu8Lgrs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nFsMehdv5qjdgdIhvqPn2QeuCXe1bKRMKMlvcOPQ8Shc0w/BXvPjeHNMk8OjJo8Xy aOcMUnsisFtO8s1Pqzk5uq+NZz0QIkgQvU3jFab2b4mSKj/eNhWtbBdrcgtCiaI9x/ CsoXMKMvDqo7yzgzFf9kX1x2Y/vVIey2LMda04NY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Doug Ledford , Jason Gunthorpe , Nicholas Bellinger , Mike Christie , Hannes Reinecke , Christoph Hellwig , Bart Van Assche , "Martin K. Petersen" Subject: [PATCH 4.19 77/99] scsi: RDMA/srpt: Fix a credit leak for aborted commands Date: Mon, 6 May 2019 16:32:50 +0200 Message-Id: <20190506143101.095873136@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143053.899356316@linuxfoundation.org> References: <20190506143053.899356316@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bart Van Assche commit 40ca8757291ca7a8775498112d320205b2a2e571 upstream. Make sure that the next time a response is sent to the initiator that the credit it had allocated for the aborted request gets freed. Cc: Doug Ledford Cc: Jason Gunthorpe Cc: Nicholas Bellinger Cc: Mike Christie Cc: Hannes Reinecke Cc: Christoph Hellwig Fixes: 131e6abc674e ("target: Add TFO->abort_task for aborted task resources release") # v3.15 Signed-off-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/ulp/srpt/ib_srpt.c | 11 +++++++++++ 1 file changed, 11 insertions(+) --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2793,8 +2793,19 @@ static void srpt_queue_tm_rsp(struct se_ srpt_queue_response(cmd); } +/* + * This function is called for aborted commands if no response is sent to the + * initiator. Make sure that the credits freed by aborting a command are + * returned to the initiator the next time a response is sent by incrementing + * ch->req_lim_delta. + */ static void srpt_aborted_task(struct se_cmd *cmd) { + struct srpt_send_ioctx *ioctx = container_of(cmd, + struct srpt_send_ioctx, cmd); + struct srpt_rdma_ch *ch = ioctx->ch; + + atomic_inc(&ch->req_lim_delta); } static int srpt_queue_status(struct se_cmd *cmd)