From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6090C04A6B for ; Mon, 6 May 2019 14:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87979205ED for ; Mon, 6 May 2019 14:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557154738; bh=e5OyHT0kIM9tCgtPrUtYgCVbFfRiUBN5ta8F6o2joag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=X0bjjHW5TXrjSi5Gcwh3P/H0qLfydJmTrnx0XXyTDv31umAWnY2psU2bcuMtxjH63 7spoRehd3tZ6BV8dFjflzVL30qrRxCtrLBTsk/najyOyn4OCC2G1GKKXu8MtPxPrXZ e+27SDjTItikUt9jHDxP0CPaUYGvGPKTkrZ7qFxM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727964AbfEFO6x (ORCPT ); Mon, 6 May 2019 10:58:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:39164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728664AbfEFOna (ORCPT ); Mon, 6 May 2019 10:43:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48C3021019; Mon, 6 May 2019 14:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557153809; bh=e5OyHT0kIM9tCgtPrUtYgCVbFfRiUBN5ta8F6o2joag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KsXscSj2T+78rgDrhkSbhQBmaYtlD0fV2A8EwBUJPJoBr1xTSBlyE06fg+EZQq8TX vBrwFoCEkYw/BrUS2U3S2E4RziqOlSjH4ZJGf16caBuPYe/o7Hcbzl4c2Y+owAvQbz U8iFyNjj7AIdRqgZ0lapmDT7MrAG/w3yyDrmKLpw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Linus Torvalds , Nadav Amit , Andy Lutomirski , Borislav Petkov , Dave Hansen , Thomas Gleixner , Ingo Molnar Subject: [PATCH 4.19 97/99] x86/mm/tlb: Revert "x86/mm: Align TLB invalidation info" Date: Mon, 6 May 2019 16:33:10 +0200 Message-Id: <20190506143102.620292973@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143053.899356316@linuxfoundation.org> References: <20190506143053.899356316@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Peter Zijlstra commit 780e0106d468a2962b16b52fdf42898f2639e0a0 upstream. Revert the following commit: 515ab7c41306: ("x86/mm: Align TLB invalidation info") I found out (the hard way) that under some .config options (notably L1_CACHE_SHIFT=7) and compiler combinations this on-stack alignment leads to a 320 byte stack usage, which then triggers a KASAN stack warning elsewhere. Using 320 bytes of stack space for a 40 byte structure is ludicrous and clearly not right. Signed-off-by: Peter Zijlstra (Intel) Acked-by: Linus Torvalds Acked-by: Nadav Amit Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Dave Hansen Cc: Peter Zijlstra Cc: Thomas Gleixner Fixes: 515ab7c41306 ("x86/mm: Align TLB invalidation info") Link: http://lkml.kernel.org/r/20190416080335.GM7905@worktop.programming.kicks-ass.net [ Minor changelog edits. ] Signed-off-by: Ingo Molnar Signed-off-by: Greg Kroah-Hartman --- arch/x86/mm/tlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -694,7 +694,7 @@ void flush_tlb_mm_range(struct mm_struct { int cpu; - struct flush_tlb_info info __aligned(SMP_CACHE_BYTES) = { + struct flush_tlb_info info = { .mm = mm, };