From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E1BC04AAD for ; Tue, 7 May 2019 05:34:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C12F21655 for ; Tue, 7 May 2019 05:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557207252; bh=7Z761sNeO2nvTu5s6V6Emy+f8PxvWLCpKr4OVlqQjQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MUzZ+aAhqR8dFPFHMQWniYowsEavG3BWQs80PrF5OlL3U8+JJYuSv+ln+GWP5odGJ 9ip405yQeChX4lSflx5b6gyT8619lLCbAmx8K4b7YxxoCIai047qAss/9+jKJaYqOM 6CX3EGtUAstsTuBj4gkCP9zBYqQ4/qIpMQbARa/s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726544AbfEGFeL (ORCPT ); Tue, 7 May 2019 01:34:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:54052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727444AbfEGFeK (ORCPT ); Tue, 7 May 2019 01:34:10 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB73C20989; Tue, 7 May 2019 05:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557207249; bh=7Z761sNeO2nvTu5s6V6Emy+f8PxvWLCpKr4OVlqQjQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oL1Ft6cXRMISbzGfqyD+kMpJ7cjlBiLWhLmjfnuoT7Z3MFaTKbDGdQcL5HSecAFkH XWBrOpyROyKwaZrfmr9V28G4O78P3W0ffcRaL1jQGdZZPWE6D/OIKPc4dtTQtGPALb w+O/v+bLV5+IWl+tTnEHJ4an4JHT1cf6jrU7FVls= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiri Olsa , Bastian Beischer , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Peter Zijlstra , Sasha Levin Subject: [PATCH AUTOSEL 5.0 50/99] perf top: Always sample time to satisfy needs of use of ordered queuing Date: Tue, 7 May 2019 01:31:44 -0400 Message-Id: <20190507053235.29900-50-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190507053235.29900-1-sashal@kernel.org> References: <20190507053235.29900-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jiri Olsa [ Upstream commit 1e6db2ee86e6a4399fc0ae5689e55e0fd1c43caf ] Bastian reported broken 'perf top -p PID' command, it won't display any data. The problem is that for -p option we monitor single thread, so we don't enable time in samples, because it's not needed. However since commit 16c66bc167cc we use ordered queues to stash data plus later commits added logic for dropping samples in case there's big load and we don't keep up. All this needs timestamp for sample. Enabling it unconditionally for perf top. Reported-by: Bastian Beischer Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Peter Zijlstra Cc: bastian beischer Fixes: 16c66bc167cc ("perf top: Add processing thread") Link: http://lkml.kernel.org/r/20190415125333.27160-1-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/builtin-top.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 616408251e25..63750a711123 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1393,6 +1393,7 @@ int cmd_top(int argc, const char **argv) * */ .overwrite = 0, .sample_time = true, + .sample_time_set = true, }, .max_stack = sysctl__max_stack(), .annotation_opts = annotation__default_options, -- 2.20.1