From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 825ABC04AAD for ; Tue, 7 May 2019 05:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A8132087F for ; Tue, 7 May 2019 05:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557208770; bh=GZHlb0ZCvWD3FA2wtQ7A+3iNqoUuSvGsLtsouGGwzBg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0ka+kCDXMqI42go+mp6fJb+fiYpNElBwugKl+5uQxQxPPHWQY1Wot6h3KTMpSzUUE tnE+P/1kcrS1DEvyctO2ILU5gA1rmcbVQs37FOaNTpxXanBzlQct9VaE4hZYp5/FhZ d6f5qFvtOelp0seyRNaIZ0Gd+67oeCI3OG4lp0Ts= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbfEGF7T (ORCPT ); Tue, 7 May 2019 01:59:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:56584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728170AbfEGFgr (ORCPT ); Tue, 7 May 2019 01:36:47 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFA6521479; Tue, 7 May 2019 05:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557207406; bh=GZHlb0ZCvWD3FA2wtQ7A+3iNqoUuSvGsLtsouGGwzBg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YShogdLOpBOfh/e960firAIkzTQzbAPmGKSayzM7iyX0rs8tYdf9y7/hJqLrD2JXg zBTLaeds1w96wL3wF6H7VTn14PjP8Dw55JGn9OABG8rZuZsYmVAHjLd/ZNj3gvbFy6 DzHZIwUgq5qlfqcaYuWgrdUM/eUbI3k3NLu50SBk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Marc Dionne , David Howells , Jonathan Billings , Sasha Levin , linux-afs@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 27/81] afs: Unlock pages for __pagevec_release() Date: Tue, 7 May 2019 01:34:58 -0400 Message-Id: <20190507053554.30848-27-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190507053554.30848-1-sashal@kernel.org> References: <20190507053554.30848-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marc Dionne [ Upstream commit 21bd68f196ca91fc0f3d9bd1b32f6e530e8c1c88 ] __pagevec_release() complains loudly if any page in the vector is still locked. The pages need to be locked for generic_error_remove_page(), but that function doesn't actually unlock them. Unlock the pages afterwards. Signed-off-by: Marc Dionne Signed-off-by: David Howells Tested-by: Jonathan Billings Signed-off-by: Sasha Levin --- fs/afs/write.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/afs/write.c b/fs/afs/write.c index 19c04caf3c01..e00461a6de9a 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c @@ -253,6 +253,7 @@ static void afs_kill_pages(struct address_space *mapping, first = page->index + 1; lock_page(page); generic_error_remove_page(mapping, page); + unlock_page(page); } __pagevec_release(&pv); -- 2.20.1