From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDF6EC004C9 for ; Tue, 7 May 2019 14:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DD6620989 for ; Tue, 7 May 2019 14:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557238430; bh=mjdFGwwOnKVIrVi45uvuiRFe3/cX2qeCwTGz3dUy0Kg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=JL5KMzcLASOdiVoXOen6D8RRvekn7S7QD/HaFP5eJBMaP7wBXmcjJXzEodQLXaVrw /NBTfmwu8QsY6B1MEax0lrzxrVHH/PTZd8KHTahpA5e7GOfVvLG2lCVOvXCGjZoDvr CE66icpkKTOBdat4O+7j1ZuEgdUDjht77my7jDCo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbfEGONt (ORCPT ); Tue, 7 May 2019 10:13:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:33576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726063AbfEGONt (ORCPT ); Tue, 7 May 2019 10:13:49 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 143D62087F; Tue, 7 May 2019 14:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557238428; bh=mjdFGwwOnKVIrVi45uvuiRFe3/cX2qeCwTGz3dUy0Kg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lxB89NazciAzmWLPcaYInGMewi23ldKwznAmX9DJnMQqyTZbnJqAs1Z9etpVbAI5a qKcSGIYw5ona7JNwl1DubsRno1UQqfUO6QCjfaWmCcGAR7iBgeoNzRtrCHr8dAfLwA WgNqsCmaTdIXAoLSULY5EtT6I151yfQfDpJe4tnQ= Date: Tue, 7 May 2019 23:13:40 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Linus Torvalds , Peter Zijlstra , Andy Lutomirski , Linux List Kernel Mailing , Ingo Molnar , Andrew Morton , Andy Lutomirski , Nicolai Stange , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Shuah Khan , Konrad Rzeszutek Wilk , Tim Chen , Sebastian Andrzej Siewior , Mimi Zohar , Juergen Gross , Nick Desaulniers , Nayna Jain , Masahiro Yamada , Joerg Roedel , "open list:KERNEL SELFTEST FRAMEWORK" , stable , Masami Hiramatsu Subject: Re: [RFC][PATCH 1/2] x86: Allow breakpoints to emulate call functions Message-Id: <20190507231340.92b1b0665d1110f90929d878@kernel.org> In-Reply-To: <20190506174511.2f8b696b@gandalf.local.home> References: <20190502181811.GY2623@hirez.programming.kicks-ass.net> <20190502193129.664c5b2e@gandalf.local.home> <20190502195052.0af473cf@gandalf.local.home> <20190503092959.GB2623@hirez.programming.kicks-ass.net> <20190503092247.20cc1ff0@gandalf.local.home> <2045370D-38D8-406C-9E94-C1D483E232C9@amacapital.net> <20190506081951.GJ2606@hirez.programming.kicks-ass.net> <20190506095631.6f71ad7c@gandalf.local.home> <20190506130643.62c35eeb@gandalf.local.home> <20190506145745.17c59596@gandalf.local.home> <20190506162915.380993f9@gandalf.local.home> <20190506174511.2f8b696b@gandalf.local.home> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 6 May 2019 17:45:11 -0400 Steven Rostedt wrote: > If we go with Peter's patch, I can make this code much more sane, and > not have to worry about having ®s->sp be at the top of the stack. I > could simply, just push everything in the order of pt_regs and call the > handler. Hi Steve, I need to catch up with the origin of this series, but it seems also good to optprobe which is doing similar trick on pt_regs. If we can assume that int3 pt_regs can have a gap, optprobe can also make a gap, and it can be also used for storing destination address. Thank you, -- Masami Hiramatsu