From: Sasha Levin <sashal@kernel.org>
To: Chenbo Feng <fengc@google.com>
Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org,
kernel-team@android.com, maze@google.com, lorenzo@google.com,
Jonathan Perry <jonperry@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [stable 4.9.y 1/2] bpf: fix struct htab_elem layout
Date: Fri, 10 May 2019 16:24:44 -0400 [thread overview]
Message-ID: <20190510202444.GC14410@sasha-vm> (raw)
In-Reply-To: <20190510023354.182171-1-fengc@google.com>
On Thu, May 09, 2019 at 07:33:53PM -0700, Chenbo Feng wrote:
>From: Alexei Starovoitov <ast@fb.com>
>
>commit 9f691549f76d488a0c74397b3e51e943865ea01f upstream.
>
>when htab_elem is removed from the bucket list the htab_elem.hash_node.next
>field should not be overridden too early otherwise we have a tiny race window
>between lookup and delete.
>The bug was discovered by manual code analysis and reproducible
>only with explicit udelay() in lookup_elem_raw().
>
>Fixes: 6c9059817432 ("bpf: pre-allocate hash map elements")
>Reported-by: Jonathan Perry <jonperry@fb.com>
>Signed-off-by: Alexei Starovoitov <ast@kernel.org>
>Acked-by: Daniel Borkmann <daniel@iogearbox.net>
>Signed-off-by: David S. Miller <davem@davemloft.net>
>Signed-off-by: Chenbo Feng <fengc@google.com>
Queued both for 4.9, thank you.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-05-10 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 2:33 [stable 4.9.y 1/2] bpf: fix struct htab_elem layout Chenbo Feng
2019-05-10 2:33 ` [stable 4.9.y 2/2] bpf: convert htab map to hlist_nulls Chenbo Feng
2019-05-10 20:24 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510202444.GC14410@sasha-vm \
--to=sashal@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fengc@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonperry@fb.com \
--cc=kernel-team@android.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox