From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A625C04AA7 for ; Tue, 14 May 2019 00:45:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2DEA21880 for ; Tue, 14 May 2019 00:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557794742; bh=2dlFT5AfiE3crXCJA7cmneM0Ha+jZ7zu6pQo81eyP/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fpSEN8s6F81T11yEXaJ4TK7WCC/UTuHN+VJQodOfDH1AKUI1181UJ8CWuWqvnZy/e qxppftFM7dNF7bKsKpZffL7Dcd0CtD3BHjlVYEzSqhKaP5opEsR857tPFKJWSbXzFq tKAiYfHVPuxB2jPbOMOKuQ9OwvN8DDzJMw9Qhk0U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726830AbfENApm (ORCPT ); Mon, 13 May 2019 20:45:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:49134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfENApm (ORCPT ); Mon, 13 May 2019 20:45:42 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22DC22168B; Tue, 14 May 2019 00:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557794741; bh=2dlFT5AfiE3crXCJA7cmneM0Ha+jZ7zu6pQo81eyP/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UwPjuifrrPf4cd6uE/oE3jx5E0lMlLQCc7cV0BuarSJbDS90SopjgwZq9XUND0NBS I5ZLblUD2UWVFgCRxGulCLNeOBiu8p65CSAg9lOA3eibhICHlbTb25R1BbT5ES5ucj J0B66x/Cn93E9PO8huT8sm7hl8dKIwevyuoqrRqs= Date: Mon, 13 May 2019 20:45:39 -0400 From: Sasha Levin To: "George G. Davis" Cc: Fabio Estevam , stable@vger.kernel.org, shawnguo@kernel.org, andrew@lunn.ch, baruch@tkos.co.il, ken.lin@advantech.com, smoch@web.de, stwiss.opensource@diasemi.com, linux-imx@nxp.com, kernel@pengutronix.de, Marc Kleine-Budde , aford173@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] ARM: dts: imx: Fix the AR803X phy-mode Message-ID: <20190514004539.GG11972@sasha-vm> References: <20190403221241.4753-1-festevam@gmail.com> <20190513171826.GA18591@mam-gdavis-lt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190513171826.GA18591@mam-gdavis-lt> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, May 13, 2019 at 01:18:27PM -0400, George G. Davis wrote: >Hello, > >On Wed, Apr 03, 2019 at 07:12:41PM -0300, Fabio Estevam wrote: >> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") >> exposed an issue on imx DTS files using AR8031/AR8035 PHYs. >> >> The end result is that the boards can no longer obtain an IP address >> via UDHCP, for example. >> >> Quoting Andrew Lunn: >> >> "The problem here is, all the DTs were broken since day 0. However, >> because the PHY driver was also broken, nobody noticed and it >> worked. Now that the PHY driver has been fixed, all the bugs in the >> DTs now become an issue" >> >> To fix this problem, the phy-mode property needs to be "rgmii-id", which >> has the following meaning as per >> Documentation/devicetree/bindings/net/ethernet.txt: >> >> "RGMII with internal RX and TX delays provided by the PHY, the MAC should >> not add the RX or TX delays in this case)" >> >> Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with >> successfully restored networking. >> >> Based on the initial submission from Steve Twiss for the >> imx6qdl-sabresd. >> >> Signed-off-by: Fabio Estevam >> Tested-by: Baruch Siach >> Tested-by: Soeren Moch >> Tested-by: Steve Twiss >> Tested-by: Adam Thomson >> Signed-off-by: Steve Twiss >> Tested-by: Marc Kleine-Budde >> Signed-off-by: Marc Kleine-Budde >> --- >> Changes since v2: >> - Also fixed imx6q-ba16 >> - Removed stable tag as it does not apply cleanly on older >> stable trees. I can manually generate versions for stable >> trees after this one hits mainline. > >Please add this commit to the v5.1.x stable queue to resolve NFS root breakage >in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root >breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts >and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x >stable series as well, it does not cause problems for pre-v5.1 but results in >NFS root breakage for v5.1.x. What's the commit id in Linus's tree? I don't see it. -- Thanks, Sasha