From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4473DC04AA7 for ; Tue, 14 May 2019 01:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 197CC2085A for ; Tue, 14 May 2019 01:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726412AbfENBQW (ORCPT ); Mon, 13 May 2019 21:16:22 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:54254 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726233AbfENBQW (ORCPT ); Mon, 13 May 2019 21:16:22 -0400 Received: from svr-orw-mbx-01.mgc.mentorg.com ([147.34.90.201]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hQM39-0004Ny-44 from George_Davis@mentor.com ; Mon, 13 May 2019 18:16:11 -0700 Received: from localhost (147.34.91.1) by svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 13 May 2019 18:16:08 -0700 Date: Mon, 13 May 2019 21:16:07 -0400 From: "George G. Davis" To: Sasha Levin CC: Fabio Estevam , , , , , , , , , , Marc Kleine-Budde , , Subject: Re: [PATCH v3] ARM: dts: imx: Fix the AR803X phy-mode Message-ID: <20190514011606.GA18528@mam-gdavis-lt> References: <20190403221241.4753-1-festevam@gmail.com> <20190513171826.GA18591@mam-gdavis-lt> <20190514004539.GG11972@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190514004539.GG11972@sasha-vm> User-Agent: Mutt/1.5.24 (2015-08-30) X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, May 13, 2019 at 08:45:39PM -0400, Sasha Levin wrote: > On Mon, May 13, 2019 at 01:18:27PM -0400, George G. Davis wrote: > >Hello, > > > >On Wed, Apr 03, 2019 at 07:12:41PM -0300, Fabio Estevam wrote: > >>Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") > >>exposed an issue on imx DTS files using AR8031/AR8035 PHYs. > >> > >>The end result is that the boards can no longer obtain an IP address > >>via UDHCP, for example. > >> > >>Quoting Andrew Lunn: > >> > >>"The problem here is, all the DTs were broken since day 0. However, > >>because the PHY driver was also broken, nobody noticed and it > >>worked. Now that the PHY driver has been fixed, all the bugs in the > >>DTs now become an issue" > >> > >>To fix this problem, the phy-mode property needs to be "rgmii-id", which > >>has the following meaning as per > >>Documentation/devicetree/bindings/net/ethernet.txt: > >> > >>"RGMII with internal RX and TX delays provided by the PHY, the MAC should > >>not add the RX or TX delays in this case)" > >> > >>Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with > >>successfully restored networking. > >> > >>Based on the initial submission from Steve Twiss for the > >>imx6qdl-sabresd. > >> > >>Signed-off-by: Fabio Estevam > >>Tested-by: Baruch Siach > >>Tested-by: Soeren Moch > >>Tested-by: Steve Twiss > >>Tested-by: Adam Thomson > >>Signed-off-by: Steve Twiss > >>Tested-by: Marc Kleine-Budde > >>Signed-off-by: Marc Kleine-Budde > >>--- > >>Changes since v2: > >>- Also fixed imx6q-ba16 > >>- Removed stable tag as it does not apply cleanly on older > >>stable trees. I can manually generate versions for stable > >>trees after this one hits mainline. > > > >Please add this commit to the v5.1.x stable queue to resolve NFS root breakage > >in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root > >breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts > >and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x > >stable series as well, it does not cause problems for pre-v5.1 but results in > >NFS root breakage for v5.1.x. > > What's the commit id in Linus's tree? I don't see it. Er, um, sorry, it was deferred to linux-next commit 68e9c97161b3 ("serial: sh-sci: disable DMA for uart_console"), which quite frankly rather annoyed me personally since linux-next commit 68e9c97161b3 is required to fix a regression caused by v5.1 commit 6d4cd041f0af. In my opinion, linux-next commit 68e9c97161b3 really should have been pushed to the v5.1 release, earlier, due to the noted regression, but I'm happy to wait for linux-next commit 68e9c97161b3 to make it to Linus's tree before propagating it to linux-stable. Meanwhile, I wanted to let you know that v5.1.x is rather broken, in this regard, on i.MX6 as-is for now. > > -- > Thanks, > Sasha -- Regards, George