From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FE7C04E53 for ; Wed, 15 May 2019 12:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D678620657 for ; Wed, 15 May 2019 12:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557921623; bh=LtofVvZstFJWa7ryhqui+ZKyM7kxlhNzJg9AGipqSFE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eEsLJzK9wSE04IDkQD7hZW4RLFGOo30DdmiLp5NS6f3iMw0cIOOgQ5Ku5I9Q2ihv2 UY/1s0co1S3+Hz90pL2zwr2Vslt4GDusq7A254mhLI7iCO/cL1eEfHkALYn5ES+HvH mb68AH/D0CnvHBwg29kBygS2oah8cp6SAlBsstoE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730191AbfEOLOv (ORCPT ); Wed, 15 May 2019 07:14:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:51018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730179AbfEOLOs (ORCPT ); Wed, 15 May 2019 07:14:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9342F2084E; Wed, 15 May 2019 11:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918887; bh=LtofVvZstFJWa7ryhqui+ZKyM7kxlhNzJg9AGipqSFE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jpFW991gXwi7O8+1s56iikQQgZ2R/tPK6VAIr9jEGoFm1zZuvuXCJJNL0t6sDhSlR Y1a/rFLbzP8TgYjLV4P00BuSq2SYJ9XnwXsjMmqGTlRMWAb5RItD+maRrLGmkrKeZ9 /NuWYAL2R4FCf/gsujFGXW/JM1Bq/Gd7j3L0tS1M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Weimer , Carlos ODonell , "H. J. Lu" , Alistair Strachan , Borislav Petkov , Laura Abbott , Andy Lutomirski , "H. Peter Anvin" , Ingo Molnar , Joel Fernandes , kernel-team@android.com, Thomas Gleixner , X86 ML , Nobuhiro Iwamatsu Subject: [PATCH 4.9 38/51] x86/vdso: Pass --eh-frame-hdr to the linker Date: Wed, 15 May 2019 12:56:13 +0200 Message-Id: <20190515090627.613209093@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090616.669619870@linuxfoundation.org> References: <20190515090616.669619870@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Alistair Strachan commit cd01544a268ad8ee5b1dfe42c4393f1095f86879 upstream. Commit 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") accidentally broke unwinding from userspace, because ld would strip the .eh_frame sections when linking. Originally, the compiler would implicitly add --eh-frame-hdr when invoking the linker, but when this Makefile was converted from invoking ld via the compiler, to invoking it directly (like vmlinux does), the flag was missed. (The EH_FRAME section is important for the VDSO shared libraries, but not for vmlinux.) Fix the problem by explicitly specifying --eh-frame-hdr, which restores parity with the old method. See relevant bug reports for additional info: https://bugzilla.kernel.org/show_bug.cgi?id=201741 https://bugzilla.redhat.com/show_bug.cgi?id=1659295 Fixes: 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") Reported-by: Florian Weimer Reported-by: Carlos O'Donell Reported-by: "H. J. Lu" Signed-off-by: Alistair Strachan Signed-off-by: Borislav Petkov Tested-by: Laura Abbott Cc: Andy Lutomirski Cc: Carlos O'Donell Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: Joel Fernandes Cc: kernel-team@android.com Cc: Laura Abbott Cc: stable Cc: Thomas Gleixner Cc: X86 ML Link: https://lkml.kernel.org/r/20181214223637.35954-1-astrachan@google.com Signed-off-by: Nobuhiro Iwamatsu Signed-off-by: Greg Kroah-Hartman --- arch/x86/entry/vdso/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/x86/entry/vdso/Makefile +++ b/arch/x86/entry/vdso/Makefile @@ -167,7 +167,8 @@ quiet_cmd_vdso = VDSO $@ sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@' VDSO_LDFLAGS = -shared $(call ld-option, --hash-style=both) \ - $(call ld-option, --build-id) -Bsymbolic + $(call ld-option, --build-id) $(call ld-option, --eh-frame-hdr) \ + -Bsymbolic GCOV_PROFILE := n #