From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13022C04E53 for ; Wed, 15 May 2019 16:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D497420881 for ; Wed, 15 May 2019 16:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557936481; bh=ou1Q0p8nGkTNT18Xc8ESYIbdZxgB31tfMhfsVCo9z3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=lph9MBwfn1B/xKuPnAzhN5oQd4ijeGYtc7LWFYBl2utdN4hmfKAGurwbMcLSBCatN 20z0S2RpyrNkXZ1SIp8Vr/69uxkW+CNIxchXEsxjDOD+/Iey1VE04Cgr+0JHYC+4EF ge+UHh1zaqIS/qsdlbCHqxl03oeodqmQPaPW7FRY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbfEOQIB (ORCPT ); Wed, 15 May 2019 12:08:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:50980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbfEOQIB (ORCPT ); Wed, 15 May 2019 12:08:01 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A3DA20862; Wed, 15 May 2019 16:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557936480; bh=ou1Q0p8nGkTNT18Xc8ESYIbdZxgB31tfMhfsVCo9z3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NGyp2ztWQBzmoeoD92lZPgGCPqUOLo3PtzxFMvGIPuFEIBus1g11X3yDLNJ+u4YBF /kMenAXzbVvXE8ucLwSdNAoaZ7aJ9hwnHyUwzkaj/lmvq0ximjquuQKtl195xngYnW gtf8fso8iZ4uKaB06MLKpq3/mDHqSSePuIBWwPcE= Date: Wed, 15 May 2019 12:07:58 -0400 From: Sasha Levin To: Nathan Chancellor Cc: Greg Kroah-Hartman , Nobuhiro Iwamatsu , stable@kernel.org, Alistair Strachan , Florian Weimer , Carlos O'Donell , "H. J. Lu" , Borislav Petkov , Laura Abbott , Andy Lutomirski , "H. Peter Anvin" , Ingo Molnar , Joel Fernandes , kernel-team@android.com, stable , Thomas Gleixner , X86 ML Subject: Re: [PATCH for 4.4, 4.9 and 4.14] x86/vdso: Pass --eh-frame-hdr to the linker Message-ID: <20190515160758.GO11972@sasha-vm> References: <20190514073429.17537-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20190514075004.GD27017@kroah.com> <20190515002531.GA12671@archlinux-i9> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190515002531.GA12671@archlinux-i9> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, May 14, 2019 at 05:25:31PM -0700, Nathan Chancellor wrote: >On Tue, May 14, 2019 at 09:50:04AM +0200, Greg Kroah-Hartman wrote: >> On Tue, May 14, 2019 at 04:34:29PM +0900, Nobuhiro Iwamatsu wrote: >> > From: Alistair Strachan >> > >> > commit cd01544a268ad8ee5b1dfe42c4393f1095f86879 upstream. >> > >> > Commit >> > >> > 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") >> > >> > accidentally broke unwinding from userspace, because ld would strip the >> > .eh_frame sections when linking. >> > >> > Originally, the compiler would implicitly add --eh-frame-hdr when >> > invoking the linker, but when this Makefile was converted from invoking >> > ld via the compiler, to invoking it directly (like vmlinux does), >> > the flag was missed. (The EH_FRAME section is important for the VDSO >> > shared libraries, but not for vmlinux.) >> > >> > Fix the problem by explicitly specifying --eh-frame-hdr, which restores >> > parity with the old method. >> > >> > See relevant bug reports for additional info: >> > >> > https://bugzilla.kernel.org/show_bug.cgi?id=201741 >> > https://bugzilla.redhat.com/show_bug.cgi?id=1659295 >> > >> > Fixes: 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") >> > Reported-by: Florian Weimer >> > Reported-by: Carlos O'Donell >> > Reported-by: "H. J. Lu" >> > Signed-off-by: Alistair Strachan >> > Signed-off-by: Borislav Petkov >> > Tested-by: Laura Abbott >> > Cc: Andy Lutomirski >> > Cc: Carlos O'Donell >> > Cc: "H. Peter Anvin" >> > Cc: Ingo Molnar >> > Cc: Joel Fernandes >> > Cc: kernel-team@android.com >> > Cc: Laura Abbott >> > Cc: stable >> > Cc: Thomas Gleixner >> > Cc: X86 ML >> > Link: https://lkml.kernel.org/r/20181214223637.35954-1-astrachan@google.com >> > Signed-off-by: Nobuhiro Iwamatsu >> > --- >> > arch/x86/entry/vdso/Makefile | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> >> This is already in the 4.14 stable queue. >> >> Sasha, how did you tools miss it for 4.4 and 4.9? > >Not Sasha's fault but mine, I forgot to git grep for the short hash like >I usually do to ensure I catch all fixes (or I didn't do it properly, I >forget which) when I added this to all of the trees. It was also the case the two patches (including the one in question here) did not have a reference to the upstream commit id, which is how my tools missed it. I've reverted both and reapplied them with a reference to the upstream commit yesterday. -- Thanks, Sasha