From: Greg KH <gregkh@linuxfoundation.org>
To: "Tomislav Požega" <pozega.tomislav@gmail.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Benjamin Berg <benjamin@sipsolutions.net>,
Simon Wunderlich <sw@simonwunderlich.de>,
Mathias Kretschmer <mathias.kretschmer@fit.fraunhofer.de>,
Kalle Valo <kvalo@qca.qualcomm.com>
Subject: Re: [PATCH 4.9] ath10k: allow setting coverage class
Date: Mon, 20 May 2019 11:45:25 +0200 [thread overview]
Message-ID: <20190520094525.GA23521@kroah.com> (raw)
In-Reply-To: <1558345149-3274-1-git-send-email-pozega.tomislav@gmail.com>
On Mon, May 20, 2019 at 11:39:09AM +0200, Tomislav Požega wrote:
> From: Benjamin Berg <benjamin@sipsolutions.net>
>
> Unfortunately ath10k does not generally allow modifying the coverage class
> with the stock firmware and Qualcomm has so far refused to implement this
> feature so that it can be properly supported in ath10k. If we however know
> the registers that need to be modified for proper operation with a higher
> coverage class, then we can do these modifications from the driver.
>
> This is a hack and might cause subtle problems but as it's not enabled by
> default (only when user space changes the coverage class explicitly) it should
> not cause new problems for existing setups. But still this should be considered
> as an experimental feature and used with caution.
>
> This patch implements the support for first generation cards (QCA9880, QCA9887
> and so on) which are based on a core that is similar to ath9k. The registers
> are modified in place and need to be re-written every time the firmware sets
> them. To achieve this the register status is verified after certain WMI events
> from the firmware.
>
> The coverage class may not be modified temporarily right after the card
> re-initializes the registers. This is for example the case during scanning.
>
> Thanks to Sebastian Gottschall <s.gottschall@dd-wrt.com> for initially
> working on a userspace support for this. This patch wouldn't have been
> possible without this documentation.
>
> Signed-off-by: Benjamin Berg <benjamin@sipsolutions.net>
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
> Signed-off-by: Mathias Kretschmer <mathias.kretschmer@fit.fraunhofer.de>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
> Signed-off-by: Tomislav Požega <pozega.tomislav@gmail.com>
> ---
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
prev parent reply other threads:[~2019-05-20 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 9:39 [PATCH 4.9] ath10k: allow setting coverage class Tomislav Požega
2019-05-20 9:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520094525.GA23521@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benjamin@sipsolutions.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.kretschmer@fit.fraunhofer.de \
--cc=pozega.tomislav@gmail.com \
--cc=stable@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).