From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9D92C04AAC for ; Mon, 20 May 2019 12:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A53BE21019 for ; Mon, 20 May 2019 12:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558354793; bh=Uvs3clkJNKhmVbhA9rwlfctk+Ze2Df4btxTxQ9DOH5M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=US4vyJPxLs+pEqjzCniQ/f88AXKJs/cllS8XnP6dNGdSfbgzFH1LzPRKV/KneU3Ej 8UZtZSwBH9iZm4WkHgZaWJXhHCtGqsCMwgW0hQ5ngivaH1qTkwT5yAOFzVjCew6onV XmF8NhNRAlvakSP2js2YPelfvrINRQZ21Y74zulQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387897AbfETMTx (ORCPT ); Mon, 20 May 2019 08:19:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:33138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732272AbfETMTw (ORCPT ); Mon, 20 May 2019 08:19:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD64320815; Mon, 20 May 2019 12:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558354792; bh=Uvs3clkJNKhmVbhA9rwlfctk+Ze2Df4btxTxQ9DOH5M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nk6ysGLH2bshkMEmoCl5qpA4TvBc47QES2UgEwwDxmasyLnu401W4OWCjmm4dKgMB 7SS7eoI3Z1hyINo7Tc/b9DWHKaeOfNwTQVeC/Wi44qKtT9hgjnZXVF/vFvMBf68+vy BoSMyydWyJZv3gNZyvePWur/Bb5hbn/e35dxXRmw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Theodore Tso , Jan Kara , stable@kernel.org Subject: [PATCH 4.14 43/63] ext4: avoid drop reference to iloc.bh twice Date: Mon, 20 May 2019 14:14:22 +0200 Message-Id: <20190520115235.831144044@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190520115231.137981521@linuxfoundation.org> References: <20190520115231.137981521@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Pan Bian commit 8c380ab4b7b59c0c602743810be1b712514eaebc upstream. The reference to iloc.bh has been dropped in ext4_mark_iloc_dirty. However, the reference is dropped again if error occurs during ext4_handle_dirty_metadata, which may result in use-after-free bugs. Fixes: fb265c9cb49e("ext4: add ext4_sb_bread() to disambiguate ENOMEM cases") Signed-off-by: Pan Bian Signed-off-by: Theodore Ts'o Reviewed-by: Jan Kara Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/resize.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -849,6 +849,7 @@ static int add_new_gdb(handle_t *handle, err = ext4_handle_dirty_metadata(handle, NULL, gdb_bh); if (unlikely(err)) { ext4_std_error(sb, err); + iloc.bh = NULL; goto errout; } brelse(dind);