From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 634F6C04AAC for ; Mon, 20 May 2019 12:37:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39C88216B7 for ; Mon, 20 May 2019 12:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558355842; bh=vIMZwcspRXs6UE0wqwuiB7o5LD4AFYlbuJzRP06lmfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=C/k3HptPohltTvtMKVVaISnMP1GNsEDapHr/VxUfJ+Op1xH38VPFwWRG9KuMpY30p KN10gs66ALyVLDKB/cFdZQjHezXKcwP9vD50D5sTFEhyDyIuBtk8Q4cTap4vNtHQul xdr1Z2pS5aQDb4u0/J/rpG9rOD8s2YsMI0op78YE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389313AbfETMhR (ORCPT ); Mon, 20 May 2019 08:37:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:55810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403898AbfETMgm (ORCPT ); Mon, 20 May 2019 08:36:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD714204FD; Mon, 20 May 2019 12:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558355802; bh=vIMZwcspRXs6UE0wqwuiB7o5LD4AFYlbuJzRP06lmfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w0RyGaW9iFVjNTynEbFsRWx9Z5Syqzsi1Z1J7DYD4KQbachxGnVKSz2OxFd+bw3KC goB9UakYBvHcheswscMYP2MRH8K90R3U1+R6LkCfKusO3FCu6XS6A7rXVLrHJ/VfXS ZnRzp02fNwHGsag/oXrPRhmx2Dj38yDgaaEhQE3w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kirill Tkhai , Theodore Tso , Jan Kara , stable@kernel.org Subject: [PATCH 5.1 090/128] ext4: actually request zeroing of inode table after grow Date: Mon, 20 May 2019 14:14:37 +0200 Message-Id: <20190520115255.464349699@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190520115249.449077487@linuxfoundation.org> References: <20190520115249.449077487@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kirill Tkhai commit 310a997fd74de778b9a4848a64be9cda9f18764a upstream. It is never possible, that number of block groups decreases, since only online grow is supported. But after a growing occured, we have to zero inode tables for just created new block groups. Fixes: 19c5246d2516 ("ext4: add new online resize interface") Signed-off-by: Kirill Tkhai Signed-off-by: Theodore Ts'o Reviewed-by: Jan Kara Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -978,7 +978,7 @@ mext_out: if (err == 0) err = err2; mnt_drop_write_file(filp); - if (!err && (o_group > EXT4_SB(sb)->s_groups_count) && + if (!err && (o_group < EXT4_SB(sb)->s_groups_count) && ext4_has_group_desc_csum(sb) && test_opt(sb, INIT_INODE_TABLE)) err = ext4_register_li_request(sb, o_group);