From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D4CC28CC2 for ; Thu, 30 May 2019 03:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 511E324B53 for ; Thu, 30 May 2019 03:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559187760; bh=VW8zFYc7LGrG75ibVxxccs8Ca2UPAcd4Hcgipwg08j4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=w4dh5/iqC023u6PIk+hyAx2f4nI2Q9jKso00FHGUo4mVhdaYbIFX5HmSeGaiXrJh0 SKl+PmadBIWgSjnv5qiodCIVUGmb16JKhrRCeVI55JMhSvxkYaSqMt12yAKtaIInhb N1m6YL84xZ6pVAE3h3N2osPBMWE7GMcvL0DCLGRY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732450AbfE3DVG (ORCPT ); Wed, 29 May 2019 23:21:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:32988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732446AbfE3DVF (ORCPT ); Wed, 29 May 2019 23:21:05 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57BB624987; Thu, 30 May 2019 03:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186465; bh=VW8zFYc7LGrG75ibVxxccs8Ca2UPAcd4Hcgipwg08j4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Po1Dh8ClUabIQGyQ9v4GfdcU6d3/I5lYdW0KmE8D9kOx9OQL31FawMihh9mBVAEs0 Dbk1cqlGbDuMIWcdwTT5dADeNqaYbnX+9q/dXa/yNYvYj5A4cXR6d6uS9VZeZtBILh 71w+BSCBKFOsMuQXGUwQZWnY3rDvQgtyzbw9vsCQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Kalle Valo , Sasha Levin Subject: [PATCH 4.9 044/128] net: cw1200: fix a NULL pointer dereference Date: Wed, 29 May 2019 20:06:16 -0700 Message-Id: <20190530030442.526928158@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030432.977908967@linuxfoundation.org> References: <20190530030432.977908967@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 0ed2a005347400500a39ea7c7318f1fea57fb3ca ] In case create_singlethread_workqueue fails, the fix free the hardware and returns NULL to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/st/cw1200/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/st/cw1200/main.c b/drivers/net/wireless/st/cw1200/main.c index dc478cedbde0d..84624c812a15f 100644 --- a/drivers/net/wireless/st/cw1200/main.c +++ b/drivers/net/wireless/st/cw1200/main.c @@ -345,6 +345,11 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr, mutex_init(&priv->wsm_cmd_mux); mutex_init(&priv->conf_mutex); priv->workqueue = create_singlethread_workqueue("cw1200_wq"); + if (!priv->workqueue) { + ieee80211_free_hw(hw); + return NULL; + } + sema_init(&priv->scan.lock, 1); INIT_WORK(&priv->scan.work, cw1200_scan_work); INIT_DELAYED_WORK(&priv->scan.probe_work, cw1200_probe_work); -- 2.20.1