From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE87C28CC1 for ; Thu, 30 May 2019 03:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F9F924850 for ; Thu, 30 May 2019 03:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186352; bh=1+NEvxVg+VyEhWUudJCfJo8Fp+MEJmWFP1uRG3tBdow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=f1Ut746GTd8aMJ/B5Ylncq54DwK6/6AT8PO+hjGLSou5E457ES4SwWFTSSY1FrqGs WLr9NI/aN/r7tZPykbn940FXRMmS4PWgBMoNAKUNofBaQDWgC0G8YWFzcL3I0V4u1Z PS+ZZl7hpMCxmtjMnRtvXtbjzTdKNNbSUczUTOSU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731829AbfE3DTL (ORCPT ); Wed, 29 May 2019 23:19:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:53966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731817AbfE3DTK (ORCPT ); Wed, 29 May 2019 23:19:10 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1875624843; Thu, 30 May 2019 03:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186350; bh=1+NEvxVg+VyEhWUudJCfJo8Fp+MEJmWFP1uRG3tBdow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zVRHlatf7MqDhwykTLOXcVnkUkrEAhVGtH3pV80RkA5T3JPyAxfcK/SpcmH/V5eVq KqfBdtoIA2AFh0704JhJWlPHVfe+bIxHqkEEiOA+zzb1h8SpebdgSG2mNgBVYM+FzG B/IgSnGX5pYniWJbV5HguaEp3rCnMgrzO9UhnI58= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Zabel , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 088/193] media: coda: clear error return value before picture run Date: Wed, 29 May 2019 20:05:42 -0700 Message-Id: <20190530030501.238922281@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030446.953835040@linuxfoundation.org> References: <20190530030446.953835040@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit bbeefa7357a648afe70e7183914c87c3878d528d ] The error return value is not written by some firmware codecs, such as MPEG-2 decode on CodaHx4. Clear the error return value before starting the picture run to avoid misinterpreting unrelated values returned by sequence initialization as error return value. Signed-off-by: Philipp Zabel Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/coda/coda-bit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c index 3457a5f1c8a8e..6eee55430d46a 100644 --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -1948,6 +1948,9 @@ static int coda_prepare_decode(struct coda_ctx *ctx) /* Clear decode success flag */ coda_write(dev, 0, CODA_RET_DEC_PIC_SUCCESS); + /* Clear error return value */ + coda_write(dev, 0, CODA_RET_DEC_PIC_ERR_MB); + trace_coda_dec_pic_run(ctx, meta); coda_command_async(ctx, CODA_COMMAND_PIC_RUN); -- 2.20.1