From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B784FC072B1 for ; Thu, 30 May 2019 04:06:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83F5E2505F for ; Thu, 30 May 2019 04:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559189160; bh=iN+ZevbI47rr7dBCWtilagq3hg+Z4snnLSYgPyCO8hg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ms+LPAMu2kFXZ4jIFEgMoaGFzDsLBbSi91csQGwe/9KpuZoEcXnpasV8u+fxSrbJL 0AoAR4ykxaiYUWjt95rhrZo9bEvU8gzcenle+gIbgd46WQB7DXCUD899ZUMgTBYGT8 7Un2pvTSweRjUjOV/0gE3AAvQMTj403RMV/USvjQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbfE3EFv (ORCPT ); Thu, 30 May 2019 00:05:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:47936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730354AbfE3DRj (ORCPT ); Wed, 29 May 2019 23:17:39 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A586A2465C; Thu, 30 May 2019 03:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186258; bh=iN+ZevbI47rr7dBCWtilagq3hg+Z4snnLSYgPyCO8hg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MRIvhOc2MRUynSMm1ozNdHLMeVRkXeUv+t09BbDag/55PjPYO60TAeFaZh2ETyVBx 197C0b4PtomCT6VnCN1CSJ2OSAnBUCGi4dEbHs6BS2NsmkydseiVIutnNomB/pnelW szrxqmIkgphy2zX4kwCtuuBOu4sW1L1mBsq+GTyk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Daniel T. Lee" , Daniel Borkmann , Sasha Levin Subject: [PATCH 4.19 190/276] selftests/bpf: ksym_search wont check symbols exists Date: Wed, 29 May 2019 20:05:48 -0700 Message-Id: <20190530030537.066337512@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 0979ff7992fb6f4eb837995b12f4071dcafebd2d ] Currently, ksym_search located at trace_helpers won't check symbols are existing or not. In ksym_search, when symbol is not found, it will return &syms[0](_stext). But when the kernel symbols are not loaded, it will return NULL, which is not a desired action. This commit will add verification logic whether symbols are loaded prior to the symbol search. Signed-off-by: Daniel T. Lee Signed-off-by: Daniel Borkmann Signed-off-by: Sasha Levin --- tools/testing/selftests/bpf/trace_helpers.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/bpf/trace_helpers.c b/tools/testing/selftests/bpf/trace_helpers.c index cabe2a3a3b300..cf156b3536798 100644 --- a/tools/testing/selftests/bpf/trace_helpers.c +++ b/tools/testing/selftests/bpf/trace_helpers.c @@ -51,6 +51,10 @@ struct ksym *ksym_search(long key) int start = 0, end = sym_cnt; int result; + /* kallsyms not loaded. return NULL */ + if (sym_cnt <= 0) + return NULL; + while (start < end) { size_t mid = start + (end - start) / 2; -- 2.20.1