From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23441C28CC0 for ; Thu, 30 May 2019 04:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1CF325055 for ; Thu, 30 May 2019 04:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559189151; bh=5fioCsNuVKfp+dVL/Jb9n4sQ/DuqOvenb4BPghvFY1o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ltvaRLcObWPLFQaqIiTaJIYmgD6McTTHOIpINGuprqX1nQkIZLiKDJPsO9VyJl8ig sWilbEb9WBwgc1F+67DHA27TfjNZPA/LBJ8W7r/bT+c/TTfQIUa3e43Ydfh9ZmxwT3 cSCfiJhHPCcVpWqfj+YKZhdzCCUYqXQx3xnUCKBQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731199AbfE3DRj (ORCPT ); Wed, 29 May 2019 23:17:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:47976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729740AbfE3DRj (ORCPT ); Wed, 29 May 2019 23:17:39 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1835C24704; Thu, 30 May 2019 03:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186259; bh=5fioCsNuVKfp+dVL/Jb9n4sQ/DuqOvenb4BPghvFY1o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XPJq/eIhQlRAcyr7iNnWCKxpIA6dBeDRv1UM7E4mIB+PEd4ExBv/vpk5Tl1GjrITi 3uMQxZXJIgH9MY5oba9lkJU9D1ED4E/INKW8wcKBddpoZTgyXq+aDz7YB24a+5wQY4 hgsGI2uldgDpXUEWKDWLclYK0IN67qIPalsPA4MA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 191/276] rtlwifi: fix a potential NULL pointer dereference Date: Wed, 29 May 2019 20:05:49 -0700 Message-Id: <20190530030537.115752224@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030523.133519668@linuxfoundation.org> References: <20190530030523.133519668@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 765976285a8c8db3f0eb7f033829a899d0c2786e ] In case alloc_workqueue fails, the fix reports the error and returns to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtlwifi/base.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c index ef9b502ce576b..a3189294ecb80 100644 --- a/drivers/net/wireless/realtek/rtlwifi/base.c +++ b/drivers/net/wireless/realtek/rtlwifi/base.c @@ -469,6 +469,11 @@ static void _rtl_init_deferred_work(struct ieee80211_hw *hw) /* <2> work queue */ rtlpriv->works.hw = hw; rtlpriv->works.rtl_wq = alloc_workqueue("%s", 0, 0, rtlpriv->cfg->name); + if (unlikely(!rtlpriv->works.rtl_wq)) { + pr_err("Failed to allocate work queue\n"); + return; + } + INIT_DELAYED_WORK(&rtlpriv->works.watchdog_wq, (void *)rtl_watchdog_wq_callback); INIT_DELAYED_WORK(&rtlpriv->works.ips_nic_off_wq, -- 2.20.1