From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CAB7C28CC0 for ; Thu, 30 May 2019 03:11:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 597822449A for ; Thu, 30 May 2019 03:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559185889; bh=iz/wcUtn3HwNE5WJyUgZwR7jVEuVPxyiJJgdZNhCOAA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vyowmckRQHvaXxVHSPX17n93Lg0J7XtGi3wtIKYig3AcVMTPjaa7CjU7/HySzuUTc 1QMbOWOiUdh7kY+6q9qupMYcVsfmxXU+A7rRy5UbtTmj7X+/vavRuPNHs+gZ8kV1Nb yXs+oSVP5UzwXZtYkQCZgpmnjJ1630/z0ucBg120= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727760AbfE3DL2 (ORCPT ); Wed, 29 May 2019 23:11:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:51096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728099AbfE3DL2 (ORCPT ); Wed, 29 May 2019 23:11:28 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98F7224496; Thu, 30 May 2019 03:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559185887; bh=iz/wcUtn3HwNE5WJyUgZwR7jVEuVPxyiJJgdZNhCOAA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UnltFIc44wpWS1rxeG+0JbcKsEf5hQnO3VgWxZjbKGku8ocD4xdY0m4z+TKuxIj1w 9KpKoPzjCfb6FBVTsGX980CAwaTLolwb21JquqwrREPP70QxXYjr25o06RoQDv1RFr Gs/LyLD3/ZlKIaJMV8ADc9ZZxjefQ3jcs+2kNtOI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Daniel T. Lee" , Daniel Borkmann , Sasha Levin Subject: [PATCH 5.1 246/405] selftests/bpf: ksym_search wont check symbols exists Date: Wed, 29 May 2019 20:04:04 -0700 Message-Id: <20190530030553.433172310@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030540.291644921@linuxfoundation.org> References: <20190530030540.291644921@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 0979ff7992fb6f4eb837995b12f4071dcafebd2d ] Currently, ksym_search located at trace_helpers won't check symbols are existing or not. In ksym_search, when symbol is not found, it will return &syms[0](_stext). But when the kernel symbols are not loaded, it will return NULL, which is not a desired action. This commit will add verification logic whether symbols are loaded prior to the symbol search. Signed-off-by: Daniel T. Lee Signed-off-by: Daniel Borkmann Signed-off-by: Sasha Levin --- tools/testing/selftests/bpf/trace_helpers.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/bpf/trace_helpers.c b/tools/testing/selftests/bpf/trace_helpers.c index 4cdb63bf0521d..9a9fc6c9b70b5 100644 --- a/tools/testing/selftests/bpf/trace_helpers.c +++ b/tools/testing/selftests/bpf/trace_helpers.c @@ -52,6 +52,10 @@ struct ksym *ksym_search(long key) int start = 0, end = sym_cnt; int result; + /* kallsyms not loaded. return NULL */ + if (sym_cnt <= 0) + return NULL; + while (start < end) { size_t mid = start + (end - start) / 2; -- 2.20.1