From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, clang-built-linux@googlegroups.com,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH 4.19] jump_label: move 'asm goto' support test to Kconfig
Date: Mon, 3 Jun 2019 09:58:35 +0200 [thread overview]
Message-ID: <20190603075835.GE7814@kroah.com> (raw)
In-Reply-To: <20190531065159.6490-1-natechancellor@gmail.com>
On Thu, May 30, 2019 at 11:52:00PM -0700, Nathan Chancellor wrote:
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> commit e9666d10a5677a494260d60d1fa0b73cc7646eb3 upstream.
>
> Currently, CONFIG_JUMP_LABEL just means "I _want_ to use jump label".
>
> The jump label is controlled by HAVE_JUMP_LABEL, which is defined
> like this:
>
> #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL)
> # define HAVE_JUMP_LABEL
> #endif
>
> We can improve this by testing 'asm goto' support in Kconfig, then
> make JUMP_LABEL depend on CC_HAS_ASM_GOTO.
>
> Ugly #ifdef HAVE_JUMP_LABEL will go away, and CONFIG_JUMP_LABEL will
> match to the real kernel capability.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> [nc: Fix trivial conflicts in 4.19
> arch/xtensa/kernel/jump_label.c doesn't exist yet
> Ensured CC_HAVE_ASM_GOTO and HAVE_JUMP_LABEL were sufficiently
> eliminated]
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>
> Hi Greg and Sasha,
>
> Please pick up this patch for 4.19. It fixes some warnings in the boot
> code for x86 when using clang because that Makefile steamrolls
> KBUILD_CFLAGS so CC_HAVE_ASM_GOTO is not defined, which triggers the
> warnings in arch/x86/include/asm/cpufeature.h on line 143.
>
> I've tested this with GCC 9.1.0 and a clang 9.0.0 build with asm goto
> support on arm, arm64, and x86_64 and CONFIG_CC_HAS_ASM_GOTO and
> CONFIG_JUMP_LABEL get enabled properly.
Now applied, thanks.
greg k-h
prev parent reply other threads:[~2019-06-03 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 6:52 [PATCH 4.19] jump_label: move 'asm goto' support test to Kconfig Nathan Chancellor
2019-06-03 7:58 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603075835.GE7814@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=mpe@ellerman.id.au \
--cc=natechancellor@gmail.com \
--cc=sashal@kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=stable@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).