From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1AF3C28CC6 for ; Mon, 3 Jun 2019 09:15:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CFB027F11 for ; Mon, 3 Jun 2019 09:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559553303; bh=/jvRGkAHeY0UxBUHI1p2McTbmOlfpHyaJxWBuDG9t14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kVGTH+2PdZXvNGf3Jb2LVDw3qU7ByCRnKtVNbPgEb7Xdr/qIYEOlXkp1bJCQoEPRO Qlx7zc96K9WroiKEWr0OfSUO8RMJNtZ2S/NLQuYGh+fqw3D9vBHyYBn5K+m4x9q/J0 HTmGCGjAzlPmcq7f6pxwhZXvSbc8kU6UpKiNZweU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728588AbfFCJO6 (ORCPT ); Mon, 3 Jun 2019 05:14:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:35032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728989AbfFCJOT (ORCPT ); Mon, 3 Jun 2019 05:14:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4273F27EDC; Mon, 3 Jun 2019 09:14:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559553258; bh=/jvRGkAHeY0UxBUHI1p2McTbmOlfpHyaJxWBuDG9t14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xYUYVUloAJvD0e/ItEHCMxbXwAiPvdyRC+ZcHeYLiZbZ8eufmsuLw5VsDGo62Gw8m ulHnc5Jn7QtEf59+HwiXXYiocO0kkc3+lODKr3MI5gHS6hh5hGkGe2LY0isAKR+eog hRsSqS1hCo2DgfEX1djBABnpqTqG3IT6pxtlILzM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Dirk van der Merwe , "David S. Miller" Subject: [PATCH 5.1 35/40] net/tls: dont ignore netdev notifications if no TLS features Date: Mon, 3 Jun 2019 11:09:28 +0200 Message-Id: <20190603090524.649697567@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190603090522.617635820@linuxfoundation.org> References: <20190603090522.617635820@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jakub Kicinski [ Upstream commit c3f4a6c39cf269a40d45f813c05fa830318ad875 ] On device surprise removal path (the notifier) we can't bail just because the features are disabled. They may have been enabled during the lifetime of the device. This bug leads to leaking netdev references and use-after-frees if there are active connections while device features are cleared. Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure") Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tls/tls_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -1001,7 +1001,8 @@ static int tls_dev_event(struct notifier { struct net_device *dev = netdev_notifier_info_to_dev(ptr); - if (!(dev->features & (NETIF_F_HW_TLS_RX | NETIF_F_HW_TLS_TX))) + if (!dev->tlsdev_ops && + !(dev->features & (NETIF_F_HW_TLS_RX | NETIF_F_HW_TLS_TX))) return NOTIFY_DONE; switch (event) {