From: David Sterba <dsterba@suse.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org
Subject: Re: Please revert "btrfs: Honour FITRIM range constraints during free space trim" from all stable trees
Date: Tue, 4 Jun 2019 13:03:55 +0200 [thread overview]
Message-ID: <20190604110355.GX15290@suse.cz> (raw)
In-Reply-To: <20190604081920.GG6840@kroah.com>
On Tue, Jun 04, 2019 at 10:19:20AM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 29, 2019 at 01:57:52PM +0200, David Sterba wrote:
> > On Wed, May 29, 2019 at 04:33:00AM -0700, Greg Kroah-Hartman wrote:
> > > On Wed, May 29, 2019 at 01:23:14PM +0200, David Sterba wrote:
> > > > Hi,
> > > >
> > > > upon closer inspection we found a problem with the patch
> > > >
> > > > "btrfs: Honour FITRIM range constraints during free space trim"
> > > >
> > > > that has been merged to 5.1.4. This could happen with ranged FITRIM
> > > > where the range is not 'honoured' as it was supposed to.
> > > >
> > > > Please revert it and push in the next stable release so the buggy
> > > > version is not in the wild for too long.
> > > >
> > > > Affected trees:
> > > >
> > > > 5.0.18
> > > > 5.1.4
> > > > 4.9.179
> > > > 4.19.45
> > > > 4.14.122
> > > >
> > > > Master branch will have the revert too. Thanks.
> > >
> > > What is the git commit id of the revert in Linus's tree?
> >
> > The commit is not there yet, I'm going to send it with the next update
> > in a few days for 5.2-rc2.
> >
> > To shorthen the delay I hope it's possible to revert the patches without
> > the corresponding master commit but if you insist on that I'll send the
> > pull request today and will let you know the commit id.
>
> Did this ever get reverted in Linus's tree? I can't seem to find it...
The patches 2 and 4 from this patchset
https://patchwork.kernel.org/project/linux-btrfs/list/?series=126297
will implement the equivalent change. Scheduled for merge to 5.2-rc4,
the patches were not available last week.
next prev parent reply other threads:[~2019-06-04 11:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 11:23 Please revert "btrfs: Honour FITRIM range constraints during free space trim" from all stable trees David Sterba
2019-05-29 11:33 ` Greg Kroah-Hartman
2019-05-29 11:57 ` David Sterba
2019-06-04 8:19 ` Greg Kroah-Hartman
2019-06-04 11:03 ` David Sterba [this message]
2019-06-04 11:34 ` Greg Kroah-Hartman
2019-06-12 11:06 ` David Sterba
2019-05-29 16:57 ` David Sterba
2019-05-29 18:36 ` Greg Kroah-Hartman
2019-05-29 17:25 ` [PATCH for 4.14.x] Revert "btrfs: Honour FITRIM range constraints during free space trim" David Sterba
2019-05-29 17:25 ` [PATCH for 4.19.x] " David Sterba
2019-05-29 17:25 ` [PATCH for 4.9.x] " David Sterba
2019-05-29 17:25 ` [PATCH for 5.0.x] " David Sterba
2019-05-29 17:25 ` [PATCH for 5.1.x] " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604110355.GX15290@suse.cz \
--to=dsterba@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).